Skip to content

fix(node): fix flaky nestjs interceptor test #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 1 commit into from
Mar 27, 2026
+16 −15
Merged

fix(node): fix flaky nestjs interceptor test #3293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions packages/node/src/__tests__/extensions/nestjs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@ import { of, throwError, lastValueFrom } from 'rxjs'

import { PostHog } from '@/entrypoints/index.node'
import { PostHogInterceptor } from '@/extensions/nestjs'
import { waitForPromises } from '../utils'

jest.mock('../../version', () => ({ version: '1.2.3' }))

const mockedFetch = jest.spyOn(globalThis, 'fetch').mockImplementation()

const waitForFlushTimer = async (): Promise<void> => {
await waitForPromises()
jest.runOnlyPendingTimers()
await waitForPromises()
/**
* Deterministically drains all pending promises (including async chains like
* captureException's buildEventMessage) and flushes any remaining queued events.
*/
const waitForFlushTimer = async (posthog: PostHog): Promise<void> => {
await posthog.shutdown()
}

const getLastBatchEvents = (): any[] | undefined => {
Expand Down Expand Up @@ -129,7 +130,7 @@ describe('PostHogInterceptor', () => {
}

await lastValueFrom(interceptor.intercept(context, handler))
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents).toBeDefined()
Expand All @@ -155,7 +156,7 @@ describe('PostHogInterceptor', () => {
const context = createMockContext()

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchCalls = mockedFetch.mock.calls.filter((c) => (c[0] as string).includes('/batch/'))
expect(batchCalls.length).toBe(0)
Expand Down Expand Up @@ -203,7 +204,7 @@ describe('PostHogInterceptor', () => {
})

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents).toBeDefined()
Expand All @@ -228,7 +229,7 @@ describe('PostHogInterceptor', () => {
const context = createMockContext()

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchCalls = mockedFetch.mock.calls.filter((c) => (c[0] as string).includes('/batch/'))
expect(batchCalls.length).toBe(0)
Expand All @@ -246,7 +247,7 @@ describe('PostHogInterceptor', () => {
const context = createMockContext({ headers: {} })

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents).toBeDefined()
Expand All @@ -267,7 +268,7 @@ describe('PostHogInterceptor', () => {
})

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents![0].properties.$ip).toBe('10.0.0.1')
Expand All @@ -280,7 +281,7 @@ describe('PostHogInterceptor', () => {
})

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents![0].properties.$ip).toBe('10.0.0.1')
Expand All @@ -292,7 +293,7 @@ describe('PostHogInterceptor', () => {
const context = createMockContext()

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchCalls = mockedFetch.mock.calls.filter((c) => (c[0] as string).includes('/batch/'))
expect(batchCalls.length).toBe(0)
Expand All @@ -304,7 +305,7 @@ describe('PostHogInterceptor', () => {
const context = createMockContext()

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents).toBeDefined()
Expand All @@ -323,7 +324,7 @@ describe('PostHogInterceptor', () => {
const context = createMockContext()

await expect(lastValueFrom(interceptor.intercept(context, createMockCallHandler(error)))).rejects.toThrow(error)
await waitForFlushTimer()
await waitForFlushTimer(posthog)

const batchEvents = getLastBatchEvents()
expect(batchEvents).toBeDefined()
Expand Down
Loading