Skip to content

ci(library-ci): add build: false to unit, functional, and lint jobs #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pauldambra merged 2 commits into from
Mar 27, 2026
+2 −2
Merged

ci(library-ci): add build: false to unit, functional, and lint jobs #3289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
879c7d6
ci(library-ci): add build: false to unit, functional, and lint jobs
mendral-app[bot] Mar 26, 2026
451d366
fix(library-ci): restore build step for unit and functional test jobs
mendral-app[bot] Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/library-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ jobs:
- uses: actions/checkout@v6
- name: Setup environment
uses: ./.github/actions/setup
with:
build: true
- run: pnpm test:functional
Comment on lines 221 to 224
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 functional job still builds after this change

The PR removes the explicit build: true from the functional job, but the setup action's build input defaults to "true" (see .github/actions/setup/action.yaml line 16). Removing build: true without replacing it with build: false leaves the job's behaviour unchanged — pnpm build still runs.

To actually skip the build, build: false needs to be specified explicitly:

Suggested change
- uses: actions/checkout@v6
- name: Setup environment
uses: ./.github/actions/setup
with:
build: true
- run: pnpm test:functional
- name: Setup environment
uses: ./.github/actions/setup
with:
build: false
- run: pnpm test:functional
Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/library-ci.yml
Line: 221-224

Comment:
**`functional` job still builds after this change**

The PR removes the explicit `build: true` from the `functional` job, but the setup action's `build` input defaults to `"true"` (see `.github/actions/setup/action.yaml` line 16). Removing `build: true` without replacing it with `build: false` leaves the job's behaviour unchanged — `pnpm build` still runs.

To actually skip the build, `build: false` needs to be specified explicitly:

```suggestion
      - name: Setup environment
        uses: ./.github/actions/setup
        with:
          build: false
      - run: pnpm test:functional
```

How can I resolve this? If you propose a fix, please make it concise.

Comment on lines 222 to 224
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Set functional setup build input to false

The functional job still runs a full pnpm build on every CI run because .github/actions/setup/action.yaml defaults inputs.build to "true" (see its input default and conditional build step). In this change, the with block was removed instead of setting build: false, so behavior remains equivalent to the previous build: true and the intended runtime/cost reduction is not realized for this job.

Useful? React with 👍 / 👎.


lint:
Expand All @@ -232,6 +230,8 @@ jobs:
- uses: actions/checkout@v6
- name: Setup environment
uses: ./.github/actions/setup
with:
build: false
- name: Lint all packages
run: pnpm lint
- name: Lint playground files
Expand Down
Loading