fix(ci): add --ignoreConfig to tsc calls in minimum TS version check for TS 6.0 compat#3288
Merged
pauldambra merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
…for TS 6.0 compat
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/minimum-version-ts-check.yaml
Line: 21-26
Comment:
**`--ignoreConfig` not available in TypeScript 4.7.4 or 5.9.2**
`--ignoreConfig` was introduced in TypeScript 6.0 (PR #62477, merged November 24, 2025). TypeScript 4.7.4 and 5.9.2 do not recognize this flag, so passing it to those versions will cause `error TS5023: Unknown compiler option 'ignoreConfig'` — breaking 6 of the 12 matrix jobs.
The TS5112 error only occurs starting with TypeScript 6.0, so the fix only needs to target the `latest` (and `6.0.0-dev.20251204`) entries. The `4.7.4` and `5.9.2` entries should keep their original flags unchanged:
```suggestion
- version: "4.7.4"
extra-flags: "--moduleResolution node"
- version: "5.9.2"
extra-flags: "--moduleResolution node"
- version: "latest"
extra-flags: "--moduleResolution node --ignoreConfig"
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(ci): add --ignoreConfig to tsc calls..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Contributor
|
Size Change: 0 B Total Size: 6.57 MB ℹ️ View Unchanged
|
… node10 deprecation
pauldambra
approved these changes
Mar 26, 2026
pauldambra
deleted the
mendral/fix-ts6-ignoreconfig-minimum-version-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tscnow refuses to loadtsconfig.jsonunless--ignoreConfigis passedlatest,4.7.4, and5.9.2matrix entries in the minimum TS version check were missing--ignoreConfig, causing thelatestjob to fail now thatlatestresolves to TS 6.0.26.0.0-dev.20251204entry already had--ignoreConfig— this PR adds it to the remaining three entriesNote
Created by Mendral. Tag @mendral-app with feedback or questions.