Bugfix for canSeeCache when request is null#60
Open
meme-lord wants to merge 1 commit intoPortSwigger:masterfrom
Open
Bugfix for canSeeCache when request is null#60meme-lord wants to merge 1 commit intoPortSwigger:masterfrom
meme-lord wants to merge 1 commit intoPortSwigger:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for #55 .
Somehow a nullpointer is passed to canSeeCache so I just null check it. I don't have time to see why that's happening and maybe you would be more able to figure that out when you have time but this fix works and allows the attack to complete for the moment.
I have also added an error message for when this happens so that it isn't silently ignored.