Conversation
- Advance day_time/game_time locally at 20 TPS with server SetTime packets as reconciliation - Only update day_time when server sends clock data - Add partial-tick interpolation for smooth sub-frame sky animation - Apply cubic Bezier easing to sun/moon/star angles - Fix celestial_rotate to correct Y(-90°) * X(angle) rotation - Fix sunrise/sunset glow transform so the glow tracks the sun - Use separate translucent and overlay (additive) blend pipelines - Drive clear color from sky_color and chunk fog from fog_color - Use camera's actual FOV for sky projection - Skip dark disc rendering when above world horizon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
/time set night- sky should immediately darken, sun should be below horizon/time set day- sky should immediately brighten