add name decoding.... oh and remove jest testing >_>#156
Open
Conversation
Owner
Author
|
@RoelN want to give this a spin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds name table string decoding based on platform and encoding id, albeit only limited to mac, shift jis, and big5. Everything else is currently still considered "then it must be regular text already".
This PR also strips out Jest because it's horrendously out of date and just makes tests that use modern JS break (it literally broke every test because whatever it does, that doesn't support
new TextDecoder()).And of course for good measure this adds a test that confirms the name string from the IBM Plex Sans Thai font actually matches
Mike Abbink, Paul van der Laan, Pieter van Rosmalen, Ben Mitchell, Mark Frömbergwith the o-umlaut in Frömberg.partially addresses #85