This repository was archived by the owner on May 29, 2019. It is now read-only.
Conversation
ghost
requested review from
arthurevans
reviewed
Sep 14, 2018
app/3.0/toolbox/xss.md
Outdated
|
|
||
| Developers using any web technology must take extreme care with APIs like [innerHTML](https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML) and [insertAdjacentHTML](https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentHTML) that directly manipulate DOM. If you use these APIs, you must guarantee that any HTML strings you pass to them are free from possibly malicious code. See the [MDN documentation on innerHTML](https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML) for more info. | ||
|
|
||
| Polymer developers , an extra consideration applies to these APIs, in that we must also rule out the evaluation of untrusted custom element templates. |
There was a problem hiding this comment.
Eliminate "we" -- suggest maybe "Polymer developers must also guard against the evaluation of untrusted code in custom element templates."
added 3 commits
September 18, 2018 12:40
Author
|
Ready for another look, thanks @arthurevans. @kevinpschaaf LMK your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review
Staged: https://xss-stuff-dot-polymer-project.appspot.com/