-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add Safe wallet limit order example #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TetrisIsCute
wants to merge
1
commit into
Polymarket:main
Choose a base branch
from
TetrisIsCute:feat/safe-wallet-limit-order-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { ethers } from "ethers"; | ||
| import { config as dotenvConfig } from "dotenv"; | ||
| import { resolve } from "path"; | ||
|
|
||
| import { safeAbi } from "../../src/abis"; | ||
| import { | ||
| CLOB_API_URL, | ||
| EXCHANGE_PROXY_ADDRESS, | ||
| CHAIN_ID, | ||
| } from "../../src/constants"; | ||
| import { buildLimitOrder } from "../../src/orders"; | ||
| import { signAndExecuteSafeTransaction } from "../../src/safe-helpers"; | ||
| import { SafeTransaction } from "../../src/types"; | ||
|
|
||
| dotenvConfig({ path: resolve(__dirname, "../../.env") }); | ||
|
|
||
| async function main() { | ||
| console.log("Starting safe limit order example..."); | ||
|
|
||
| const provider = new ethers.providers.JsonRpcProvider( | ||
| process.env.RPC_URL as string, | ||
| ); | ||
| const eoa = new ethers.Wallet(process.env.PK as string, provider); | ||
|
|
||
| console.log(`EOA: ${eoa.address}`); | ||
|
|
||
| // =========== Replace the values below with your own =========== | ||
|
|
||
| const safeAddress = ""; // Your Safe address | ||
| const marketTokenId = ""; // Polymarket market token id | ||
| const side = "BUY"; // or "SELL" | ||
| const price = "0.10"; | ||
| const size = "1.0"; | ||
| const expiration = Math.floor(Date.now() / 1000) + 60 * 10; // 10 minutes | ||
|
|
||
| // =============================================================== | ||
|
|
||
| const safe = new ethers.Contract(safeAddress, safeAbi, eoa); | ||
|
|
||
| const order = buildLimitOrder({ | ||
| maker: safeAddress, | ||
| taker: ethers.constants.AddressZero, | ||
| tokenId: marketTokenId, | ||
| side, | ||
| price, | ||
| size, | ||
| expiration, | ||
| exchangeAddress: EXCHANGE_PROXY_ADDRESS, | ||
| chainId: CHAIN_ID, | ||
| }); | ||
|
|
||
| const tx: SafeTransaction = { | ||
| to: EXCHANGE_PROXY_ADDRESS, | ||
| value: 0, | ||
| data: order.calldata, | ||
| operation: 0, | ||
| }; | ||
|
|
||
| console.log("Signing and executing Safe transaction..."); | ||
|
|
||
| await signAndExecuteSafeTransaction({ | ||
| safe, | ||
| tx, | ||
| apiUrl: CLOB_API_URL, | ||
| }); | ||
|
|
||
| console.log("Done."); | ||
| } | ||
|
|
||
| main().catch((err) => { | ||
| console.error(err); | ||
| process.exit(1); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong function signature for
signAndExecuteSafeTransactioncallThe
signAndExecuteSafeTransactionfunction is called with an object argument, but the actual function insrc/safe-helpers/index.tsexpects positional arguments:(signer: Wallet, safe: Contract, txn: SafeTransaction, overrides?). All other examples in the codebase correctly call it assignAndExecuteSafeTransaction(wallet, safe, safeTxn, {gasPrice: ...}). The new code is missing thesigner/wallet argument entirely and incorrectly passes an object with non-existent properties likeapiUrl. This will cause the script to fail at runtime.