Add profit notification example #121
Open
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a script that periodically checks position P&L and prints a message when profits exceed a configurable threshold.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| positions = client.get_positions() | ||
| for p in positions: | ||
| profit = p.unrealized_pnl | ||
| if profit >= THRESHOLD: |
There was a problem hiding this comment.
Comparison uses >= but documentation says "exceeds"
The comparison profit >= THRESHOLD uses greater-than-or-equal, but the docstring, PR description, and print message all state the notification triggers when profit "exceeds" the threshold. In financial contexts, "exceeds" typically means strictly greater than (>). When profit exactly equals the threshold, the notification will fire with a message claiming it "exceeds" the threshold, which is semantically incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script that periodically checks position P&L and prints a message when profits exceed a configurable threshold.
Note
Adds a small utility script to monitor unrealized PnL and notify when it exceeds a threshold.
scripts/python/notify_on_profit.pypollsPolymarket.get_positions()and prints whenunrealized_pnl>=PROFIT_THRESHOLDPROFIT_THRESHOLDandCHECK_INTERVALenv vars; read-only (no trades)Written by Cursor Bugbot for commit 1d15129. This will update automatically on new commits. Configure here.