Create python-type-check.yml #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a GitHub Action to run mypy on the agents package and scripts, catching type errors in pull requests.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| python-version: "3.10" | ||
| - run: | | ||
| python -m pip install --upgrade pip | ||
| pip install .[dev] |
There was a problem hiding this comment.
Workflow depends on missing pyproject.toml file
The workflow uses pip install .[dev] which requires a pyproject.toml file with a [dev] extra defined, but this file doesn't exist in the repository. The existing workflow in python-app.yml uses pip install -r requirements.txt instead. Additionally, mypy itself is not listed in requirements.txt (only mypy-extensions is present), so even if installation succeeded, the mypy command would fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Action to run mypy on the agents package and scripts, catching type errors in pull requests.
Note
Adds a CI workflow to run
mypyon relevant Python code in PRs.python-type-check.ymltriggers on changes toagents/**/*.py,scripts/python/**/*.py,pyproject.toml, or the workflow itself.[dev], and runsmypy agents scripts/pythonWritten by Cursor Bugbot for commit aec9ffb. This will update automatically on new commits. Configure here.