Skip to content

feat (source): make version separator configurable #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simbuerg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat (source): make version separator configurable #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions benchbuild/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,16 @@
"default": True
},
"multithread": {
"desc": "Hint SLURM to disable multithreading. False adds --hint=nomultithread.",
"default": False
"desc":
"Hint SLURM to disable multithreading. False adds --hint=nomultithread.",
"default":
False
},
"turbo": {
"desc": "Enable Intel Turbo Boost via SLURM. False adds --pstate-turbo=off.",
"default": False
"desc":
"Enable Intel Turbo Boost via SLURM. False adds --pstate-turbo=off.",
"default":
False
},
"logs": {
"desc": "Location the SLURM logs will be stored",
Expand Down Expand Up @@ -384,13 +388,15 @@
},
"storage_driver": {
"default": None,
"desc": "Storage driver for containers."
"If 'null' use podman's default."
"desc":
"Storage driver for containers."
"If 'null' use podman's default."
},
"storage_opts": {
"default": [],
"desc": "Storage options for containers."
"If 'null', ignore 'storage.conf'."
"desc":
"Storage options for containers."
"If 'null', ignore 'storage.conf'."
},
"seccomp_config": {
"default": None,
Expand Down Expand Up @@ -517,6 +523,10 @@
}

CFG["versions"] = {
"separator": {
"default": ",",
"desc": "Separator used to join versions."
},
"full": {
"default": False,
"desc": "Ignore default sampling and provide full version exploration."
Expand Down
2 changes: 1 addition & 1 deletion benchbuild/source/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def to_str(*variants: Variant) -> str:
Returns:
string representation of all input variants joined by ','.
"""
return ",".join([str(i) for i in variants])
return str(CFG["versions"]["separator"]).join([str(i) for i in variants])


class Fetchable(Protocol):
Expand Down
Loading