Skip to content

Change variants separator #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuAbelt wants to merge 2 commits into from
Closed

Change variants separator #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b41fd4
- Change sources seperator from comma to asterisk
Mar 11, 2025
21fcd37
- Change separator to plus
Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchbuild/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ def __add_filters__(project: ProjectT, version_str: str) -> ProjectT:

def csv(in_str: tp.Union[tp.Any, str]) -> bool:
if isinstance(in_str, str):
return len(in_str.split(",")) > 1
return len(in_str.split("+")) > 1
return False

is_csv = csv(version_in)
Expand All @@ -548,7 +548,7 @@ def csv(in_str: tp.Union[tp.Any, str]) -> bool:
return __add_single_filter__(project, str(version_in))

if isinstance(version_in, list) or is_csv:
version_in = version_in.split(",") if is_csv else version_in
version_in = version_in.split("+") if is_csv else version_in
return __add_indexed_filters__(project, version_in)

if isinstance(version_in, dict):
Expand Down
2 changes: 1 addition & 1 deletion benchbuild/source/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def to_str(*variants: Variant) -> str:
Returns:
string representation of all input variants joined by ','.
"""
return ",".join([str(i) for i in variants])
return "*".join([str(i) for i in variants])


class Fetchable(Protocol):
Expand Down