Skip to content

Consolidate computation_modules with CountryConfig from library #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anth-volk wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Consolidate computation_modules with CountryConfig from library #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598741f
refactor: Consolidate computation_modules with CountryConfig from lib…
anth-volk Mar 17, 2026
ac28f31
refactor: Replace inline Modal computation with run_modules()
anth-volk Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/policyengine_api/api/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,18 +897,17 @@ def build_dynamic(dynamic_id):
pe_reform_sim.ensure()

# Run computation modules
from policyengine_api.api.computation_modules import UK_MODULE_DISPATCH, run_modules
from policyengine_api.api.computation_modules import run_modules

run_modules(
dispatch=UK_MODULE_DISPATCH,
country_id="uk",
modules=modules,
pe_baseline_sim=pe_baseline_sim,
pe_reform_sim=pe_reform_sim,
baseline_sim_id=baseline_sim.id,
reform_sim_id=reform_sim.id,
report_id=report.id,
session=session,
country_id="uk",
)

# Mark completed
Expand Down Expand Up @@ -1082,18 +1081,17 @@ def build_dynamic(dynamic_id):
pe_reform_sim.ensure()

# Run computation modules
from policyengine_api.api.computation_modules import US_MODULE_DISPATCH, run_modules
from policyengine_api.api.computation_modules import run_modules

run_modules(
dispatch=US_MODULE_DISPATCH,
country_id="us",
modules=modules,
pe_baseline_sim=pe_baseline_sim,
pe_reform_sim=pe_reform_sim,
baseline_sim_id=baseline_sim.id,
reform_sim_id=reform_sim.id,
report_id=report.id,
session=session,
country_id="us",
)

# Mark completed
Expand Down
Loading
Loading