Fix Battle Dome Type Adjustments#58
Open
nlordell wants to merge 1 commit intoPokemonHnS-Development:mainfrom
Open
Fix Battle Dome Type Adjustments#58nlordell wants to merge 1 commit intoPokemonHnS-Development:mainfrom
nlordell wants to merge 1 commit intoPokemonHnS-Development:mainfrom
Conversation
The Battle Dome has some type adjustments based on modern/fairy type settings. These were doing incorrect checks on the pointers of the party pokemon species instead of the species values themselves.
Contributor
|
Hi! I'll be fixing this in the Modern Emerald repository as well, in which Heart and Soul is based on. Just letting you know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Battle Dome has some type adjustments based on modern/fairy type settings. These were doing incorrect checks on the pointers of the party pokemon species instead of the species values themselves.
I don't have a save file to actually test these fixes, I found them when building the project locally (the compiler warnings stuck out to me, and decided to take a look at the code).