[FIX] wrong handling of border.rectList with PySide6 backend#103
Conversation
This appears to fix the problems described in issue PlotPyStack#102 . The changes can be made more pythonic, this patch literally came out of my debugging session - feedback regarding cleaning it up and making it ready for merging would be highly appreciated
…ide6' into fix/102_test_stylesheet_fail_pyside6
Here is my proposition to keep one of the case that was implemented for issue PlotPyStack#63
The class Border has a rectList member, but some lines in drawRects() refered to a member attribute named list. This caused the test to fail again on PySide6, test passes now with these modifications.
|
Thanks for looking into this, there was still an issue, as described in the commit message. Also, shouldn't line 77 be something like to be consistent across all cases? Cheers, |
Sorry, I wrote my commit directly online without testing anything, hence the obvious mistakes. Thanks for fixing them. |
|
Thanks for the update! Cheers, |
border.rectList with PySide6 backend
This appears to fix the problems described in issue #102 . The changes can be made more pythonic, this patch literally came out of my debugging session - feedback regarding cleaning it up and making it ready for merging would be highly appreciated
Cheers,
Martin