Important fix - ensure objects are buffer aligned to fix graphics crashes#84
Open
AlexanderHarrison wants to merge 2 commits intoPloaj:masterfrom
Open
Important fix - ensure objects are buffer aligned to fix graphics crashes#84AlexanderHarrison wants to merge 2 commits intoPloaj:masterfrom
AlexanderHarrison wants to merge 2 commits intoPloaj:masterfrom
Conversation
Author
|
Looks like this isn't quite working as I expected. Working on it. |
cf22d06 to
d55de18
Compare
Author
|
I've changed to a different approach. Instead of marking the objects that need to be buffer aligned, we always buffer align all objects. Pros:
Cons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been having a ton of graphics crashes in Training Mode - More for a while. This bug was incredibly obnoxious to track down, and I don't want to make you or anyone else go through this hell, so this should be fixed (with this pr or however you prefer it done) asap.
When fixed, could you update the MexTK build with the patch?
Thanks for your hard work! This is by far the most underappreciated project in the community.