Skip to content

Fix: [BUG] [v0.0.7] cortex logout says 'Not logged in.' even when authentication is active via CORTEX_API_KEY #43657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willkhinz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: [BUG] [v0.0.7] cortex logout says 'Not logged in.' even when authentication is active via CORTEX_API_KEY #43657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions FIX_SUBMISSION.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
```python
def logout(self, force=False):
# Check if authenticated via environment variable
if 'CORTEX_API_KEY' in os.environ:
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Locate logout implementations
rg -nP --type=py -C3 '^\s*def\s+logout\s*\(\s*self\s*,\s*force'

# 2) Locate os imports
rg -nP --type=py -C2 '^\s*(import\s+os|from\s+os\s+import\b)'

Repository: PlatformNetwork/bounty-challenge

Length of output: 224

🏁 Script executed:

#!/bin/bash
# Find the patch file
find . -name "FIX_SUBMISSION.patch" -type f

# Show its contents
if [ -f "./FIX_SUBMISSION.patch" ]; then
  cat -n "./FIX_SUBMISSION.patch"
fi

Repository: PlatformNetwork/bounty-challenge

Length of output: 778

Missing os import required for os.environ usage.

Line 4 uses os.environ, but the provided patch does not include an import os statement. This code will fail at runtime with a NameError unless os is imported at the module level. Add import os to the file.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@FIX_SUBMISSION.patch` at line 4, The code references os.environ (see the if
'CORTEX_API_KEY' in os.environ check) but misses the os import; add a top-level
import os statement in the module so os.environ is defined and the runtime
NameError is prevented.

print("Authenticated via CORTEX_API_KEY environment variable. Cannot clear environment-based credentials.")
return

# Rest of the logout logic remains the same
if self.auth_token:
# Clear auth token
self.auth_token = None
print("Logged out successfully.")
Comment on lines +4 to +12
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Clear stored session before env-auth early return.

On Line 6, the early return skips token cleanup, so a persisted/in-memory session may remain when CORTEX_API_KEY is also set. That keeps logout state inconsistent.

Suggested fix 
 def logout(self, force=False):
-    # Check if authenticated via environment variable
-    if 'CORTEX_API_KEY' in os.environ:
-        print("Authenticated via CORTEX_API_KEY environment variable. Cannot clear environment-based credentials.")
-        return
+    env_api_key = os.getenv("CORTEX_API_KEY")
+    had_token = bool(self.auth_token)
+
+    # Always clear locally stored session state when present.
+    if had_token:
+        self.auth_token = None
 
-    # Rest of the logout logic remains the same
-    if self.auth_token:
-        # Clear auth token
-        self.auth_token = None
-        print("Logged out successfully.")
+    if env_api_key:
+        if had_token:
+            print("Logged out of stored session. CORTEX_API_KEY is still set; unset it to fully log out.")
+        else:
+            print("Authenticated via CORTEX_API_KEY environment variable. Unset it to log out.")
+        return
+    if had_token:
+        print("Logged out successfully.")
     elif force:
         print("Not logged in.")
     else:
         print("Not logged in. Use --yes to force logout.")
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@FIX_SUBMISSION.patch` around lines 4 - 12, The early return when
'CORTEX_API_KEY' exists prevents clearing in-memory session state; inside the
logout method ensure you clear stored session fields (e.g., set self.auth_token
= None and any other session-related attributes) before printing the env-auth
message and returning. Update the logout flow to clear self.auth_token (and
related session state) prior to the early return triggered by the CORTEX_API_KEY
check so logout state is consistent.

elif force:
print("Not logged in.")
else:
print("Not logged in. Use --yes to force logout.")
```