-
Notifications
You must be signed in to change notification settings - Fork 31
Swarm Fix: [BUG] [alpha] Editor tab strip container (.tabs-container) uses padding: 0 — no outer inset around tab row
#38275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willkhinz
wants to merge
1
commit into
PlatformNetwork:main
Choose a base branch
from
willkhinz:fix-bug-alpha-editor-tab-strip-container-tab-1774486754
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| To fix the issue of the editor tab strip container (`.tabs-container`) using `padding: 0` and not having an outer inset around the tab row, you can modify the CSS rule for `.tabs-container` to include a small padding value. | ||
|
|
||
| Here is the exact code fix: | ||
|
|
||
| ```css | ||
| .tabs-container { | ||
| display: flex; | ||
| align-items: flex-end; /* Align tabs to bottom for fusion effect */ | ||
| height: var(--editor-group-tab-height); | ||
| padding: 4px; /* Add a small padding value */ | ||
| scrollbar-width: none; /* Firefox */ | ||
| overflow: hidden; | ||
| background-color: var(--jb-panel); | ||
| /* NO border-bottom - tabs merge directly with editor */ | ||
| } | ||
| ``` | ||
|
|
||
| Alternatively, you can use a more specific padding value for each side, for example: | ||
|
|
||
| ```css | ||
| .tabs-container { | ||
| display: flex; | ||
| align-items: flex-end; /* Align tabs to bottom for fusion effect */ | ||
| height: var(--editor-group-tab-height); | ||
| padding: 2px 4px; /* Add a small padding value to the top and bottom, and a slightly larger value to the left and right */ | ||
| scrollbar-width: none; /* Firefox */ | ||
| overflow: hidden; | ||
| background-color: var(--jb-panel); | ||
| /* NO border-bottom - tabs merge directly with editor */ | ||
| } | ||
| ``` | ||
|
|
||
| You can adjust the padding values to achieve the desired amount of breathing room around the tab strip. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR does not apply the fix in product code
This file documents a workaround, but it does not change the actual
.tabs-containerstylesheet used by the app. As-is, the reported UI bug will remain unresolved. Please include the real CSS change in the target style file (and keep this doc as supplemental context if needed).🧰 Tools
🪛 LanguageTool
[style] ~1-~1: Consider using a different verb for a more formal wording.
Context: To fix the issue of the editor tab strip conta...
(FIX_RESOLVE)
🤖 Prompt for AI Agents