Conversation
Collaborator
Author
|
Hi. I've added Testium element. I've put in as a draft pull request because it is based off of the yet-to-be-merged PR #11 Please advise if Testium should work in a different way :) |
Plasdom
reviewed
Jun 19, 2025
LiamPattinson
left a comment
LiamPattinson
left a comment
There was a problem hiding this comment.
Looks good, and I'd be interested to hear about your experience using syrupy! I think the use of pytest.skip and pytest.mark.parametrize are definite improvements here.
…ta_savedir, we point to the test data directory for element=T (Testium) and the usual savedir otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an element "Testium". Currently it is equal to Helium - we can cut it down later if we want to do more heavy testing with it. The json files come to 260KB at the moment.
I have added the Testium .json files to the usual sike_atomic_data directory and instructed .gitignore to allow this Testium element specifically to be tracked.
Added a basic test for it using syrupy for dynamic snapshot testing.
Parametrised the multi-element tests.
Tests will now be skipped if elemental data has not been downloaded. Testium should always pass as my intention is that its data is kept in the GitHub under version control.