Adding remove_duplicates to llm_util#35
Closed
hnikolov-solirius wants to merge 29 commits intomainfrom
Closed
Conversation
Contributor
Author
|
Pulling StopWord list in |
hnikolov-solirius
force-pushed
the
feat/NRR-119-StopWordListv3
branch
from
e13e9d2 to
d59167e
Compare
added 8 commits
February 11, 2026 16:20
hnikolov-solirius
force-pushed
the
feat/NRR-119-StopWordListv3
branch
from
db40090 to
1e8d67f
Compare
shannon-wms
reviewed
Feb 12, 2026
| """ | ||
| stopwords = safe_load(open(os.path.join("config", "stopwords.yaml"), "r")) | ||
| stopwords_list = stopwords["stopwords"] | ||
| text_to_redact = list(set(text_to_redact) - set(stopwords_list)) |
Contributor
There was a problem hiding this comment.
I've realised a better way to do this is text_to_redact = [x for x in text_to_redact if x.lower() not in stopwords_list] (since set will alphabetise the list and you also want to match cases). This change should make all tests pass
Contributor
Author
There was a problem hiding this comment.
I like it, updated
shannon-wms
reviewed
Feb 12, 2026
Contributor
shannon-wms
left a comment
shannon-wms
left a comment
There was a problem hiding this comment.
Looks good, just some nitpicks
Read and store PDF text line-by-line with bounding boxes, and search lines to validate redaction candidates found by initially searching the PDF page. Reduces time spent on redaction without spawning additional processes.
Co-authored-by: hnikolov <hristo.nikolov@solirus.com>
* Add more comprehensive logging. Update and improve test coverage * Improve error message when writing blobs. Improve logging. Fix bug in face redaction which resulted in the bounding box being incorrect when highlighting * Improve styling * Update test case * Improve logs to be clearer Fix verbose imports * Fix broken test
Read and store PDF text line-by-line with bounding boxes, and search lines to validate redaction candidates found by initially searching the PDF page. Reduces time spent on redaction without spawning additional processes.
* Add more comprehensive logging. Update and improve test coverage * Improve error message when writing blobs. Improve logging. Fix bug in face redaction which resulted in the bounding box being incorrect when highlighting * Improve styling * Update test case * Improve logs to be clearer Fix verbose imports * Fix broken test
Read and store PDF text line-by-line with bounding boxes, and search lines to validate redaction candidates found by initially searching the PDF page. Reduces time spent on redaction without spawning additional processes.
* Add more comprehensive logging. Update and improve test coverage * Improve error message when writing blobs. Improve logging. Fix bug in face redaction which resulted in the bounding box being incorrect when highlighting * Improve styling * Update test case * Improve logs to be clearer Fix verbose imports * Fix broken test
Read and store PDF text line-by-line with bounding boxes, and search lines to validate redaction candidates found by initially searching the PDF page. Reduces time spent on redaction without spawning additional processes.
Collaborator
|
Replaced by #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placing stopword removal within analyse_text