Feat/theodw 2355 embed anonymisation raw to std dev#2442
Merged
stef-solirius merged 52 commits intomainfrom Apr 8, 2026
Merged
Feat/theodw 2355 embed anonymisation raw to std dev#2442stef-solirius merged 52 commits intomainfrom
stef-solirius merged 52 commits intomainfrom
Conversation
…it tests and integration tests
…ttps://github.com/Planning-Inspectorate/odw-synapse-workspace into feat/THEODW-2355-Embed-anonymisation-raw-to-std-DEV
…ttps://github.com/Planning-Inspectorate/odw-synapse-workspace into feat/THEODW-2355-Embed-anonymisation-raw-to-std-DEV
…ttps://github.com/Planning-Inspectorate/odw-synapse-workspace into feat/THEODW-2355-Embed-anonymisation-raw-to-std-DEV
…ttps://github.com/Planning-Inspectorate/odw-synapse-workspace into feat/THEODW-2355-Embed-anonymisation-raw-to-std-DEV
…ttps://github.com/Planning-Inspectorate/odw-synapse-workspace into feat/THEODW-2355-Embed-anonymisation-raw-to-std-DEV
…ttps://github.com/Planning-Inspectorate/odw-synapse-workspace into feat/THEODW-2355-Embed-anonymisation-raw-to-std-DEV
Update test cases to expect correct single-argument log_info calls after fixing the bug where log_info was called with two arguments. The logging_util.py fix was already committed, but the tests were not updated to match. Changes: - Renamed tests to reflect corrected behavior instead of buggy behavior - Updated assertions to expect log_info called with formatted strings - Tests now verify graceful exception handling instead of expecting TypeError
The pytest import was no longer needed after refactoring tests to not use pytest.raises. All tests still pass and ruff linting is now clean.
- Downgrade pydantic from ^2.12.5 to 1.10.0 in pyproject.toml - Replace model_dump(mode='json') with json() in py_etl_orchestrator - Replace model_dump_json() with json() in test_etl_process.py - Verified all ETL process tests pass with pydantic 1.10
Fred83200
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pins-ds.atlassian.net/browse/THEODW-2355
Key Changes
1. Anonymisation Integration in Standardisation Processes
Service Bus Standardisation (
service_bus_standardisation_process.py):Util.is_non_production_environment()AnonymisationEngineto automatically anonymise sensitive fields based on Purview classificationsHorizon Standardisation (
horizon_standardisation_process.py):2. Enhanced Anonymisation Engine (
odw/core/anonymisation/)Deterministic Anonymisation:
Improved Credential Resolution:
ls_kv) for secure credential retrievalmssparkutils.credentials.getToken()Configuration Enhancements (
config.py):seed_columnfor default anonymisation seedentity_seed_columnsfor per-entity seed column overridesStrategy Improvements (
base.py):Asset FQN Fixes:
3. Bug Fixes
py_etl_orchestrator.jsonHorizonStandardisationProcess.load_data()to prevent loading unwanted files4. Testing
5. Documentation
Environment Scope
spark.executorEnv.environmentodw-config/anonymisation/policy.yaml