feat: create private endpoint for key vault apps service#1252
Draft
m-juckes-pins wants to merge 17 commits intomainfrom
Draft
feat: create private endpoint for key vault apps service#1252m-juckes-pins wants to merge 17 commits intomainfrom
m-juckes-pins wants to merge 17 commits intomainfrom
Conversation
m-juckes-pins
force-pushed
the
task/create_private_endpoint_key_vault
branch
from
a379f0a to
fc735b9
Compare
m-juckes-pins
commented
Mar 24, 2026
| name = "snet-private-endpoints" | ||
| resource_group_name = azurerm_resource_group.common_infrastructure.name | ||
| virtual_network_name = module.networking.vnet_name | ||
| address_prefixes = ["10.0.1.0/24"] # Ensure this doesn't overlap! |
Collaborator
Author
There was a problem hiding this comment.
this ip range needs to be double checked. It may need to be moved into networking section (this did break my pipeline when i did but probably not referencing it correctly).
m-juckes-pins
commented
Mar 24, 2026
| name = "pins-pe-keyvault-${local.resource_suffix}" | ||
| location = azurerm_resource_group.common_infrastructure.location # This is throwing up errors? | ||
| resource_group_name = azurerm_resource_group.common_infrastructure.name | ||
| subnet_id = azurerm_subnet.private_endpoints.id # Not sure on which subnet it lives |
Collaborator
Author
There was a problem hiding this comment.
a new one will be created
m-juckes-pins
commented
Mar 24, 2026
|
|
||
| resource "azurerm_private_endpoint" "keyvault" { | ||
| name = "pins-pe-keyvault-${local.resource_suffix}" | ||
| location = azurerm_resource_group.common_infrastructure.location # This is throwing up errors? |
Collaborator
Author
There was a problem hiding this comment.
no errors, old code comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Describe your changes
Useful information to review or test
Type of change 🧩
Checklist before requesting a review