feat(nisp): nsip-project amountDue and invoiceStage#254
Open
KalyaniNik wants to merge 3 commits intomainfrom
Open
feat(nisp): nsip-project amountDue and invoiceStage#254KalyaniNik wants to merge 3 commits intomainfrom
KalyaniNik wants to merge 3 commits intomainfrom
Conversation
cprieststephens
left a comment
cprieststephens
left a comment
There was a problem hiding this comment.
LGTM - just added one question.
docs/nsip-project-defs-invoice.md
Outdated
| | Property | Type | Required | Nullable | Defined by | | ||
| | :------------------------------------------------ | :------- | :------- | :------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | [invoiceStage](#invoicestage) | `string` | Optional | can be null | [NSIP Project](nsip-project-defs-invoice-properties-invoicestage.md "nsip-project.schema.json#/$defs/invoice/properties/invoiceStage") | | ||
| | [invoiceStage](#invoicestage) | `string` | Optional | cannot be null | [NSIP Project](nsip-project-defs-invoice-properties-invoicestage.md "nsip-project.schema.json#/$defs/invoice/properties/invoiceStage") | |
There was a problem hiding this comment.
Apologies if I've misunderstood, does invoiceStage need to be marked as Required if it now cannot be null? Similarly, does amountDue need to marked as Optional?
cprieststephens
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nsip-project schema updated amountDue to allow null, change invoiceStage to not null as per application team