Skip to content

fix(api): exclude s51 attachments from redaction publishing validation (idas-525) #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cprieststephens wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(api): exclude s51 attachments from redaction publishing validation (idas-525) #3113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 68 additions & 50 deletions apps/api/src/server/applications/application/documents/document.validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,20 @@ export const verifyAllDocumentsHaveRequiredPropertiesForPublishing = async (

const completeDocumentsIds = new Set(completeDocuments.map((pDoc) => pDoc.guid));

// remove email documents and documents where redaction is required and not completed
const publishableDocuments = completeDocuments.filter(
(doc) =>
doc.latestDocumentVersion?.mime !== 'application/vnd.ms-outlook' &&
(doc.latestDocumentVersion?.redactedStatus === 'redacted' ||
doc.latestDocumentVersion?.redactedStatus === 'no_redaction_required')
);
// remove all email documents and, if not s51 advice attachments, remove unredacted documents
let publishableDocuments;
if (skipRequiredPropertyChecks) {
publishableDocuments = completeDocuments.filter(
(doc) => doc.latestDocumentVersion?.mime !== 'application/vnd.ms-outlook'
);
} else {
publishableDocuments = completeDocuments.filter(
(doc) =>
doc.latestDocumentVersion?.mime !== 'application/vnd.ms-outlook' &&
(doc.latestDocumentVersion?.redactedStatus === 'redacted' ||
doc.latestDocumentVersion?.redactedStatus === 'no_redaction_required')
);
}

// complete documents that are MSG files
const msgDocuments = completeDocuments.filter(
Expand Down Expand Up @@ -300,49 +307,60 @@ export const verifyAllDocumentsHaveRequiredPropertiesForPublishing = async (
// incomplete documents
const incompleteDocuments = documentIds.filter((id) => !completeDocumentsIds.has(id));

// Final array of invalid files
const invalid = [
...msgDocuments.map((doc) => ({
guid: doc.guid,
msg: "The file type .msg cannot be set to 'Ready for publish'",
type: 'invalid-filetype'
})),
...unredactedDocuments.map((doc) => ({
guid: doc.guid,
msg: 'Select redacted or redaction not needed in the document properties to be able to change the document status to ready to publish',
type: 'unredacted'
})),
...documentsAwaitingAiSuggestions.map((doc) => ({
guid: doc.guid,
msg: 'Redaction suggestions are being created and will then need to be reviewed, so the document status cannot be changed to ready to publish',
type: 'awaiting-ai-suggestions'
})),
...documentsAwaitingAiSuggestionsReview.map((doc) => ({
guid: doc.guid,
msg: 'The document contains redaction suggestions for review, so cannot be set to ready to publish',
type: 'awaiting-ai-suggestions-review'
})),
...documentsWithReviewedAiSuggestions.map((doc) => ({
guid: doc.guid,
msg: 'Finalise document redactions to be able to change the status to ready to publish',
type: 'ai-suggestions-reviewed'
})),
...documentsAwaitingAiRedaction.map((doc) => ({
guid: doc.guid,
msg: 'Finalising redactions is still in progress, so the document cannot be set to ready to publish',
type: 'awaiting-ai-redaction'
})),
...documentsWithFailedAiRedaction.map((doc) => ({
guid: doc.guid,
msg: 'Redaction failed - only redacted documents can be set to ready to publish',
type: 'ai-redaction-failed'
})),
...incompleteDocuments.map((id) => ({
guid: id,
msg: 'You must fill in all mandatory document properties to publish a document',
type: 'missing-properties'
}))
];
// create final array of invalid documents (will contain email documents only if s51 attachment)
let invalid;
if (skipRequiredPropertyChecks) {
invalid = [
...msgDocuments.map((doc) => ({
guid: doc.guid,
msg: "The file type .msg cannot be set to 'Ready for publish'",
type: 'invalid-filetype'
}))
];
} else {
invalid = [
...msgDocuments.map((doc) => ({
guid: doc.guid,
msg: "The file type .msg cannot be set to 'Ready for publish'",
type: 'invalid-filetype'
})),
...unredactedDocuments.map((doc) => ({
guid: doc.guid,
msg: 'Select redacted or redaction not needed in the document properties to be able to change the document status to ready to publish',
type: 'unredacted'
})),
...documentsAwaitingAiSuggestions.map((doc) => ({
guid: doc.guid,
msg: 'Redaction suggestions are being created and will then need to be reviewed, so the document status cannot be changed to ready to publish',
type: 'awaiting-ai-suggestions'
})),
...documentsAwaitingAiSuggestionsReview.map((doc) => ({
guid: doc.guid,
msg: 'The document contains redaction suggestions for review, so cannot be set to ready to publish',
type: 'awaiting-ai-suggestions-review'
})),
...documentsWithReviewedAiSuggestions.map((doc) => ({
guid: doc.guid,
msg: 'Finalise document redactions to be able to change the status to ready to publish',
type: 'ai-suggestions-reviewed'
})),
...documentsAwaitingAiRedaction.map((doc) => ({
guid: doc.guid,
msg: 'Finalising redactions is still in progress, so the document cannot be set to ready to publish',
type: 'awaiting-ai-redaction'
})),
...documentsWithFailedAiRedaction.map((doc) => ({
guid: doc.guid,
msg: 'Redaction failed - only redacted documents can be set to ready to publish',
type: 'ai-redaction-failed'
})),
...incompleteDocuments.map((id) => ({
guid: id,
msg: 'You must fill in all mandatory document properties to publish a document',
type: 'missing-properties'
}))
];
}

return {
publishable: publishableDocuments.map(({ guid, latestVersionId }) => ({
Expand Down
Loading