Open
Conversation
ypk
changed the title
- Updated .nvmrc from 20 to 22.22.0 - Updated package.json engines fields to >=22.0.0 <23.0.0 - Updated Docker base images to node:22-alpine3.22 - Updated Azure Pipeline files nodeVersion from 20 - Updated Turbo 2.x config by moving NODE_ENV and APP_RELEASE to env field and removed --parallel flags - Updated README.md to reflect Node 22 as current version
ypk
force-pushed
the
feat/IDAS-422-Node-22-Upgrade
branch
from
da1c7f0 to
16b1aca
Compare
- regenerated package-lock.json - fixed types in middleware
- updated failing snapshot
emil-placheta
requested changes
Mar 25, 2026
| aria-label="Page 2"> 2</a> | ||
| </li> | ||
| <li class="govuk-pagination__item govuk-pagination__item--ellipses">⋯</li> | ||
| <li class="govuk-pagination__item govuk-pagination__item--ellipsis">⋯</li> |
Collaborator
There was a problem hiding this comment.
That's unusual. How come the snapshot was out of date without a corresponding template change? Also, the CSS and template is still using the old spelling, so I am a bit confused where is this coming from?
| ### Node.js | ||
|
|
||
| The current node version can be found in the package.json at the root of the project. It is recommended to use a node version manager, such as [nvm](https://github.com/nvm-sh/nvm#installing-and-updating). | ||
| The current node version is **Node.js 22.22.0 LTS**. The version can be found in `.nvmrc` and in the `engines` field of package.json files. It is recommended to use a node version manager, such as [nvm](https://github.com/nvm-sh/nvm#installing-and-updating). |
Collaborator
There was a problem hiding this comment.
Please revert to the original comment, otherwise this will need to be updated with every node update and can be missed
Comment on lines
+16
to
+26
| // Debug: Check if we're on the right page | ||
| cy.get('body').then(($body) => { | ||
| cy.log('Current page body HTML snippet: ' + $body.html().substring(0, 500)); | ||
| }); | ||
|
|
||
| // Debug: List all form inputs on the page | ||
| cy.get('input').then(($inputs) => { | ||
| const inputIds = $inputs.map((i, el) => el.id).get(); | ||
| cy.log('Available input IDs: ' + inputIds.join(', ')); | ||
| }); | ||
|
|
Collaborator
There was a problem hiding this comment.
Why has this been included?
Contributor
Author
There was a problem hiding this comment.
I removed it in my local, I didn't commit it earlier.
removed.
Snasim21
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This upgrades node to v22
Issue ticket number and link
IDAS-422 [CBOS] Update Node to v22
Type of change 🧩
Checklist before requesting a review