fix(web): fixed incorrect banner showing when USV selected (A2-7805)#3591
Open
musabadam-pins wants to merge 1 commit intomainfrom
Open
fix(web): fixed incorrect banner showing when USV selected (A2-7805)#3591musabadam-pins wants to merge 1 commit intomainfrom
musabadam-pins wants to merge 1 commit intomainfrom
Conversation
Contributor
zoebutterworth
left a comment
zoebutterworth
left a comment
There was a problem hiding this comment.
Are there some tests which cover this area of the codebase which you could add to to cover this case?
| actions.push('addSiteVisitTime'); | ||
| if (siteVisit && siteVisit.visitType) { | ||
| switch (siteVisit.visitType.toLowerCase()) { | ||
| case 'unaccompanied': |
Contributor
There was a problem hiding this comment.
Can you use the constants SITE_VISIT_TYPE_UNACCOMPANIED, SITE_VISIT_TYPE_ACCOMPANIED and SITE_VISIT_TYPE_ACCESS_REQUIRED instead of the string values here?
| } else if (siteVisit && siteVisit.visitDate && !siteVisit.visitStartTime) { | ||
| actions.push('addSiteVisitTime'); | ||
| if (siteVisit && siteVisit.visitType) { | ||
| switch (siteVisit.visitType.toLowerCase()) { |
Contributor
There was a problem hiding this comment.
I feel that this switch is a bit unnecessary. There is quite a lot of repetition in each of the cases. I think you should be able to just add an extra statement to the if to check for unaccompanied
musabadam-pins
force-pushed
the
fix(web)-A2-7805-Add-site-visit-time-banner-displaying-incorrectly
branch
from
63d119f to
57e3187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Ticket