feat(appeals): add stored procedure for setting personal list entries and integration tests (A2-6158)#3581
Draft
ShareMyWebStuff wants to merge 1 commit intomainfrom
Draft
feat(appeals): add stored procedure for setting personal list entries and integration tests (A2-6158)#3581ShareMyWebStuff wants to merge 1 commit intomainfrom
ShareMyWebStuff wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR creates a stored procedure for setting the personal list. It is called with null to refresh all the personalList entries or with an appealId to refresh one personalList entry.
To test the stored procedure I have added to the integration tests and bootstrapped a Azure SQL database in a docker image .
I changed the decision letter tests as they run in a Promise.all and the order they are returned in isnt consistent.
Issue ticket number and link
Ticket