Skip to content

chore(appeals): performance todos and deprecations#3478

Open
bryn-pins wants to merge 2 commits intomainfrom
chore/performance-recomendations
Open

chore(appeals): performance todos and deprecations#3478
bryn-pins wants to merge 2 commits intomainfrom
chore/performance-recomendations

Conversation

@bryn-pins
Copy link
Copy Markdown
Contributor

@bryn-pins bryn-pins commented Mar 18, 2026

Describe your changes

This PR attempts to stop new uses of the inefficient calls that return all data for an appeal

  • renames some deprecated functions so that they are more obvious to spot in PR review
  • patch appeal-details was using ?include=all which is deprecated and unnecessary, the response isn't used, so the endpoint itself can decide on which lookups are needed
  • added comments for some performance issues, tickets exist as well
  • encoded uri based on github suggestion - unrelated to my changes so left in a separate commit

Issue ticket number and link

Ticket

@bryn-pins bryn-pins force-pushed the chore/performance-recomendations branch from deb2065 to 94f71f0 Compare April 1, 2026 15:06
@bryn-pins bryn-pins force-pushed the chore/performance-recomendations branch from 94f71f0 to ff52e33 Compare April 1, 2026 15:23
@bryn-pins bryn-pins marked this pull request as ready for review April 1, 2026 16:25
Copy link
Copy Markdown
Contributor

@DavidJWhiteDev DavidJWhiteDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clear, nice!

@bryn-pins bryn-pins added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@bryn-pins bryn-pins added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants