Skip to content

Conversation

@naqvis
Copy link
Contributor

@naqvis naqvis commented Oct 30, 2025

No description provided.

@naqvis naqvis requested review from chillfox and stakach October 30, 2025 12:23
@github-actions github-actions bot added the type: enhancement new feature or request label Oct 30, 2025
Copy link
Contributor

@chillfox chillfox Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the endpoints without /:id/ will need to be added to

    @[AC::Route::Filter(:before_action, except: [:index, :create, :edge_control])]
    def find_current_edge(id : String)

I think a bunch of the endpoints should be added to the other before_action scopes as well.

@naqvis naqvis requested a review from chillfox November 4, 2025 05:10
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Nov 4, 2025
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Nov 4, 2025
Copy link
Contributor

@chillfox chillfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

###############################################################################################

@[AC::Route::Filter(:before_action, except: [:index, :create, :edge_control])]
@[AC::Route::Filter(:before_action, except: [:index, :create, :edge_contro, :edges_healthl, :edges_errors, :edges_connections, :edges_module_failures, :edges_statistics, :edge_error_stream, :edges_error_stream, :edges_module_stream, :cleanup_errors, :monitoring_summary])]

This comment was marked as outdated.

@stakach stakach merged commit a42b7f7 into master Dec 16, 2025
9 of 11 checks passed
@stakach stakach deleted the PPT-11 branch December 16, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants