fix(asset_types): Refactor endpoint to respect zone_id param #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakach
requested changes
Dec 12, 2024
Member
stakach
left a comment
stakach
left a comment
There was a problem hiding this comment.
minor change to fix response header
stakach
requested changes
Dec 12, 2024
github-actions
bot
added
type: bug
Member
|
Does the asset_type test pass locally for you @naqvis ? |
Contributor
Author
Yes they do. Let me add clearing tables step to spec, so that they will pass here as well. 
|
github-actions
bot
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.