feat: user photo upload and locatable flag [PPT-2038] #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tags for uploads allowing us to filter by upload use cases
stakach
changed the title
github-actions
bot
added
type: enhancement
github-actions
bot
added
type: enhancement
naqvis
reviewed
Jun 6, 2025
| -- SQL in section 'Up' is executed when this migration is applied | ||
|
|
||
| -- 1. Add `locatable` with default TRUE and NOT NULL in one step | ||
| ALTER TABLE "user" |
Contributor
There was a problem hiding this comment.
For readability it would be good to combine these statements into one
ALTER TABLE "user"
ADD COLUMN locatable BOOLEAN NOT NULL DEFAULT true,
ADD COLUMN photo_upload_id TEXT REFERENCES uploads(id) ON DELETE SET NULL;
naqvis
reviewed
Jun 6, 2025
Comment on lines
25
to
30
| ALTER TABLE "user" | ||
| DROP COLUMN photo_upload_id; | ||
|
|
||
| -- 2. Drop `locatable` | ||
| ALTER TABLE "user" | ||
| DROP COLUMN locatable; |
Contributor
There was a problem hiding this comment.
same applies to these
ALTER TABLE "user"
DROP COLUMN locatable,
DROP COLUMN photo_upload_id;
naqvis
requested changes
Jun 6, 2025
Contributor
naqvis
left a comment
naqvis
left a comment
There was a problem hiding this comment.
LGTM. Would be good to improve readability of DDL schema
github-actions
bot
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tags for uploads allowing us to filter by upload use cases