Skip to content

Conversation

@naqvis
Copy link
Contributor

@naqvis naqvis commented Feb 18, 2025

on a separate note. PR contains whole lot of files which are updated by crystal format but interesting enough that ameba is still not coping up with latest crystal version. So both are causing conflict. Should we getting rid of ameba? as technically speaking it causes more false positives and whole lot of noise compared to the value it bring to the table. @stakach @chillfox

@naqvis naqvis requested review from chillfox and stakach February 18, 2025 05:40
@github-actions github-actions bot added the type: enhancement new feature or request label Feb 18, 2025
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Feb 18, 2025
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Feb 18, 2025
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Feb 18, 2025
Copy link
Contributor

@chillfox chillfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naqvis naqvis merged commit e8f1a2c into master Feb 19, 2025
8 of 9 checks passed
@naqvis naqvis deleted the PPT-1846 branch February 19, 2025 03:00
@chillfox
Copy link
Contributor

ameba hasn't been updated for 3 months. Is there an option for it to ignore formatting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants