Skip to content

[PROJ-1523] fix(place/auto_release): fix logic so email sends with negative time_… #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chillfox merged 6 commits into from
Oct 23, 2025
Merged

[PROJ-1523] fix(place/auto_release): fix logic so email sends with negative time_… #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b4cedd
fix(place/auto_release): fix logic so email sends with negative time_…
KesterJJ Oct 16, 2025
52d4cd0
fix(place/auto release) removed extra end
Oct 22, 2025
7f2a355
fix(place/auto_release_spec) Added expected result
Oct 22, 2025
0e416d0
fix(place/auto_release_spec) Added expected result 2
Oct 22, 2025
ff4a755
Merge branch 'master' into fix(place/auto_release)-fix-logic-so-email…
Oct 22, 2025
d989822
chore(auto_release): crystal tool format
chillfox Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions drivers/place/auto_release.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,9 @@ class Place::AutoRelease < PlaceOS::Driver

# convert minutes (time_after) to seconds for comparison with unix timestamps (booking_start)
if enabled? &&
(booking.booking_start - Time.utc.to_unix < @auto_release.time_before(booking.booking_type) * 60) &&
(Time.utc.to_unix - booking.booking_start < @auto_release.time_after(booking.booking_type) * 60)
logger.debug { "sending release email to #{booking.user_email} for booking #{booking.id} as it is withing the time_before window" }
(booking.booking_start - Time.utc.to_unix <= @auto_release.time_before(booking.booking_type) * 60) &&
(Time.utc.to_unix - booking.booking_start <= @auto_release.time_after(booking.booking_type) * 60)
logger.debug { "sending release email to #{booking.user_email} for booking #{booking.id} as it is within the time_before window" }

location = Time::Location.load(booking.timezone.presence || timezone.name)
starting = Time.unix(booking.booking_start).in(location)
Expand Down
2 changes: 2 additions & 0 deletions drivers/place/auto_release_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,7 @@ DriverSpecs.mock_driver "Place::AutoRelease" do
resp = exec(:pending_release).get
pending_release = resp.not_nil!.as_a.map(&.as_h["title"])
pending_release.should eq [
"ignore_after_hours",
"notify_created_yesterday",
"reject_created_yesterday",
"outside_hours",
Expand Down Expand Up @@ -1141,6 +1142,7 @@ DriverSpecs.mock_driver "Place::AutoRelease" do
resp = exec(:pending_release).get
pending_release = resp.not_nil!.as_a.map(&.as_h["title"])
pending_release.should eq [
"ignore_after_hours",
"notify_created_yesterday",
"reject_created_yesterday",
"outside_hours",
Expand Down
Loading