UsdAbc: translate the property's arrayExtent metadata into elementSize #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are equivalent and describe how consecutive array elements should be grouped. This is used, for example, by Houdini's Alembic exporter to translate float tuples that aren't standard data types such as positions or colors. Fixes: PixarAnimationStudios#3362
Collaborator
|
Filed as internal issue #USD-11727 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
For the example file in the referenced bug report, the Alembic property has the metadata
arrayExtent: 3, podExtent: 1, podName: float32_t.This was translated into a
float[]array with too many elements since thearrayExtentwas ignored. This metadata seems to have an equivalent meaning to USD's elementSize, describing a grouping of consecutive elements in the array.Houdini's Alembic exporter, for example, uses this in the generic case for translating float tuple attributes (which might have an arbitrary tuple size) if they're not a standard type like positions or colors.
(Note that if the property instead had metadata
arrayExtent:1, podExtent:3, this behaved correctly as-is and would translate into afloat3[]array)Link to proposal (if applicable)
N/A
Fixes Issue(s)
Fixes: #3362
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)