Add integration tests #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iAmoric
requested review from
SpectreVert,
aliculPix4D,
marco-m-pix4d and
odormond
iAmoric
commented
Jan 21, 2026
odormond
reviewed
Jan 21, 2026
iAmoric
force-pushed
the
integration-tests
branch
from
7b530be to
e22ba69
Compare
aliculPix4D
approved these changes
Jan 22, 2026
marco-m-pix4d
approved these changes
Jan 22, 2026
Contributor
marco-m-pix4d
left a comment
marco-m-pix4d
left a comment
There was a problem hiding this comment.
Pre-approving.
Please see inline.
marco-m-pix4d
added a commit
to Pix4D/cogito
that referenced
this pull request
Jan 22, 2026
As we are doing in Pix4D/go-kit#11
marco-m-pix4d
added a commit
to Pix4D/cogito
that referenced
this pull request
Jan 22, 2026
As we are doing in Pix4D/go-kit#11
iAmoric
force-pushed
the
integration-tests
branch
from
e22ba69 to
5626260
Compare
marco-m-pix4d
added a commit
to Pix4D/cogito
that referenced
this pull request
Jan 22, 2026
As we are doing in Pix4D/go-kit#11
They somehow change the response. Before it was a one-line JSON, now it's formatted with tab and new lines. Since we literally compare the string we have to normalize the response
iAmoric
force-pushed
the
integration-tests
branch
from
5626260 to
4d6d8a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCI-4471
Add Integrations tests (local and using GitHub Actions)
I had to refactor a bit some tests because the GitHub API changes the response format...
Thanks @marco-m-pix4d for the help! 🙏