Re-enable linter #175
Merged
Re-enable linter #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-m-pix4d
requested review from
SpectreVert,
aliculPix4D,
iAmoric and
odormond
and removed request for
a team
odormond
approved these changes
Jan 27, 2026
iAmoric
approved these changes
Jan 27, 2026
marco-m-pix4d
force-pushed
the
migrate-to-go-kit
branch
from
eb36749 to
da4d138
Compare
marco-m-pix4d
force-pushed
the
re-enable-linter
branch
from
ea7c734 to
aba5ad4
Compare
This is needed for Go 1.25 and has the same approach as go-kit (use GH Action for the linter), reducing the build time.
marco-m-pix4d
force-pushed
the
re-enable-linter
branch
from
aba5ad4 to
c6ba579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why the linter fixes appear now is because we updated from golanci-lint v1 to v2, and v2 has among its default linters
errcheck, while v1 hasn't.I am not 100% satisfied.