Skip to content

Conversation

@tryuan99
Copy link
Member

This PR adds an additional field to the simulation configuration for asset configurations. Since I have to regenerate all plugins (as the proto files changed), I figured I might as well bump all package versions.

@tryuan99 tryuan99 requested a review from daniellovell January 30, 2026 02:49
@stacklane-pr-stack-visualizer
Copy link

stacklane-pr-stack-visualizer bot commented Jan 30, 2026

🧱 Stack PR · Base of stack (2 PRs total)

Stack Structure:

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds asset configuration capabilities to the simulation, which is a valuable enhancement. The changes are consistently applied across protobuf definitions, generated code, and configuration files. The associated test updates are also appropriate. My main feedback is a suggestion to address the duplication of the new asset_configs block across multiple simulation files to improve long-term maintainability. Additionally, as a general process improvement, consider separating dependency updates from feature work into separate pull requests. This can make reviews more focused and simplify rollbacks if any issues arise.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

This PR adds an asset-level configuration to simulations by importing agent_config.proto and adding repeated AgentConfig asset_configs = 3 to SimulationConfig (renumbering subsequent fields), updates the proto BUILD deps to include agent_config_proto, bumps protobuf and other Bazel-module versions, adds a new CVN model pbtxt and meta file, inserts asset_configs entries into many simulation pbtxt files, updates pre-commit and Bazel versions, and adds a test assertion verifying loaded asset_configs size.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • daniellovell
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main objective of the PR: adding asset configuration support to the simulation system.
Description check ✅ Passed The description directly relates to the changeset by explaining the addition of an asset configuration field to simulation configuration and the version bumping necessitated by proto file changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch titan/asset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
plugins/MODULE.bazel (1)

3-30: ⚠️ Potential issue | 🔴 Critical

Add protobuf 33.5 override; it is not yet published in Bazel Central Registry.

The protobuf version 33.5 does not exist in BCR (which currently has up to 33.4 only), so bazel_dep(name = "protobuf", version = "33.5") will fail to resolve. Use an archive_override or git_override to point to the upstream protobuf v33.5 release until BCR publishes it. Version consistency with Assets/Proto/MODULE.bazel is correct; other dependencies (rules_cc 0.2.16, abseil-cpp 20260107.0, googletest 1.17.0) are compatible with Bazel 8.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Agent] Define an asset class

2 participants