Merged
Conversation
The PyPI sdist upload was rejected (400 Bad Request) because maturin declared License-File: LICENSE in PKG-INFO but the file was not included in the tarball. Add include = ["LICENSE"] to [tool.maturin] so the workspace-root LICENSE is bundled in the sdist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The env var shortcut for config discovery is not wanted. The --config CLI flag remains; only the clap `env = "PIPELEX_CONFIG"` attribute and all documentation references are removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Support `x-plxt` as a schema extension key with priority over `x-taplo`, following the established "plxt first, taplo fallback" pattern. Extract lookup logic into `try_schema_ext` helper and add unit tests for priority, fallback, and error handling. Also add `make build` target that builds both the CLI and VS Code extension. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename taplo-usage-guide.md → plxt-usage-guide.md and rewrite for the plxt toolchain (install via pip, plxt commands, config discovery) - Remove upstream taplo install instructions from the usage guide - Add docs/design/architecture.md consolidating crate map, config discovery, x-plxt schema extensions, and ASCII architecture diagram - Delete superseded planning docs (pipelex-tools-plan.md, pipelex-tools-certification.md) - Sharpen README, CONTRIBUTING, and VS Code README headers: tighten descriptions, unify feature lists, drop "kept in sync" labels - Update local-dev-setup.md with make build target - Minor wording fix in plxt-integration-handoff.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove .vscode/settings.json from .gitignore so workspace settings (e.g. file associations, editor preferences) are shared across the team. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The ends_with check on bare `plxt.toml` matched any path ending in those characters (e.g. `myplxt.toml`), causing spurious config reloads and skipped file-change handling in the LSP. Add a path-separator boundary check so only exact filename matches are recognized. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-plxtschema extension support —x-plxtkeys in JSON Schemas take priority overx-taplo, with a newmake buildtargetPIPELEX_CONFIGenvironment variable — simplify config discovery to file-based only.vscode/settings.jsonfor shared workspace configplxt-usage-guide.md, addarchitecture.md, delete superseded planning docs, sharpen README/CONTRIBUTING copyTest plan
cargo testpasses (core crates + pipelex crates)cargo check -p pipelex-wasm --target wasm32-unknown-unknowncompilesmake extbuilds the VS Code extension successfullypip install -e .installsplxtandplxt fmt --checkworksx-plxtschema keys are picked up in the LSP🤖 Generated with Claude Code
Note
Medium Risk
Changes config discovery semantics (new filenames and removal of
PIPELEX_CONFIGenv support) and modifies sharedtaplo-commonschema-extension parsing, which could affect LSP/CLI behavior across the toolchain.Overview
Bumps
pipelex-clito v0.1.4 and fixes Python packaging by includingLICENSEin the maturin build.Updates Pipelex config discovery to be file-based only and to prefer
.pipelex/plxt.toml(thenplxt.toml) before falling back to Taplo configs; the VS Code bundled LSP uses the same search order, andMthdsEnvironment::is_config_fileis hardened to avoid suffix collisions.Adds support for
x-plxtJSON Schema extensions intaplo-common(prioritized overx-taplo, with tests), introduces amake buildtarget, starts tracking workspace.vscode/settings.json, and refreshes/reshapes documentation (newdocs/design/architecture.md, removes superseded design docs, and updates generated READMEs/guide copy).Written by Cursor Bugbot for commit 7c69597. This will update automatically on new commits. Configure here.