mthds-4 Add hierarchical domains and pipe namespacing (Phase 1)#671
Closed
lchoquel wants to merge 3 commits intofeature/Epic-mthds-2from
Closed
mthds-4 Add hierarchical domains and pipe namespacing (Phase 1)#671lchoquel wants to merge 3 commits intofeature/Epic-mthds-2from
lchoquel wants to merge 3 commits intofeature/Epic-mthds-2from
Conversation
Introduce QualifiedRef as the centralized model for domain-qualified
reference parsing, replacing scattered .split(".")/rsplit(".") calls
across 8+ files. This enables hierarchical domains (e.g. "legal.contracts")
and domain-qualified pipe references (e.g. "scoring.compute_score"),
making pipes symmetric with the existing concept reference system.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afe1585ad5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
lchoquel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QualifiedRefmodel for hierarchical domain-qualified references (e.g.,domain.subdomain::PipeName)Test plan
QualifiedRefparsing and formatting with valid/invalid inputsmake agent-test🤖 Generated with Claude Code
Note
Medium Risk
Touches core parsing/validation for domains, concept refs, and pipe lookup; could reject previously-accepted edge-case strings or change reference resolution behavior across bundles.
Overview
Enables hierarchical domain codes (e.g.
legal.contracts) and domain-qualified references for concepts/pipes throughout bundle parsing and validation.Introduces
QualifiedRefas a central parser/validator for dotted refs, updates concept/domain/multiplicity validation to accept multi-segment domains, and tightens bundle validation by checking same-domain qualified pipe references in controller blueprints while continuing to ignore external refs and special outcomes.Updates builder
.mthdspipelines to use fully-qualified pipe codes (e.g.builder.*,pipe_design.detail_pipe_spec), and adds extensive unit + integration fixtures/tests covering valid/invalid hierarchical domains and cross-domain concept/pipe references.Written by Cursor Bugbot for commit afe1585. This will update automatically on new commits. Configure here.