Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pipes = library_manager.load_from_blueprints(library_id=library_id, blueprints=[blueprint]) | ||
| inputs_json = generate_input_memory_json_string(pipes[0].inputs) |
There was a problem hiding this comment.
The new pipe_builder implementation grabs pipes[0].inputs after loading the blueprints, ignoring the blueprint.main_pipe. For bundles with multiple pipes or when the main entry point is not first in the list, the returned inputs_format_to_run will describe a different pipe, so downstream clients will construct the wrong inputs and the execution will fail at validation/runtime.
Useful? React with 👍 / 👎.
lchoquel
left a comment
lchoquel
left a comment
There was a problem hiding this comment.
OK but Codex has a point -> TODO comment
| pipes = library_manager.load_from_blueprints(library_id=library_id, blueprints=[blueprint]) | ||
| inputs_json = generate_input_memory_json_string(pipes[0].inputs) |
2 participants
Release/v0.1.6