Support required auth configuration on the pbincli API.#13
Open
blacklight wants to merge 2 commits intoPioverpie:masterfrom
Open
Support required auth configuration on the pbincli API.#13blacklight wants to merge 2 commits intoPioverpie:masterfrom
auth configuration on the pbincli API.#13blacklight wants to merge 2 commits intoPioverpie:masterfrom
Conversation
Uploads fail if it is not defined. This also adds support for authented uploads. Two different modes are currently supported by `pbcli`: - `auth="basic"`, with `auth_user` and `auth_pass`. - `auth="custom"`, with a custom `auth_headers` dict. This also adds a round of LINT+Black to the modified files. Closes: Pioverpie#12
Author
|
Btw tests fail because some of the parametrized hostnames are now gone, have implemented rate limiting, run outdated versions or have changed their configuration: Worth updating the list? |
Author
|
FYI I've also opened an issue on PBinCli to make the parsing of the settings more robust. While support for authorized uploads is definitely almost a must-have, I also think that PBinCli shouldn't break downstream implementations between releases by adding new expected fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploads fail if it is not defined.
This also adds support for authenticated uploads. Two different modes are currently supported by
pbcli:auth="basic", withauth_userandauth_pass.auth="custom", with a customauth_headersdict.This also adds a round of LINT+Black to the modified files.
Closes: #12