Skip to content

Add Russian localization file for plugin by youngsq#68

Open
HydrolienF wants to merge 2 commits intoPimvanderLoos:masterfrom
Mvndi:ru
Open

Add Russian localization file for plugin by youngsq#68
HydrolienF wants to merge 2 commits intoPimvanderLoos:masterfrom
Mvndi:ru

Conversation

@HydrolienF
Copy link
Copy Markdown

One of our player did a russian translation of the plugin. I though you probably would like to merge it to main project.

@PimvanderLoos
Copy link
Copy Markdown
Owner

Awesome! Could you also add the new file name to this list? https://github.com/PimvanderLoos/BigDoors/blob/master/core%2Fsrc%2Fmain%2Fjava%2Fnl%2Fpim16aap2%2FbigDoors%2Futil%2FMessages.java#L21

Then it'll get extracted on startup

@HydrolienF
Copy link
Copy Markdown
Author

Done.
I thought translation where used based on the player Locale and not a global server language. We won't switch to full russian so it won't be usefull for us 😢
If one day you want to change that, I think paper docs explain pretty well how to translate in every player language if the translation file exist there: https://docs.papermc.io/adventure/localization/#using-a-translationstore

@PimvanderLoos
Copy link
Copy Markdown
Owner

Yeah, BigDoors only has a single server-wide language. I have no plans to change that at this time.

AnimatedArchitecture, on the other hand, already has all of the code required for per-player localisation, but no way to actually use it, yet. I'll definitely take a look at your link for AnimatedArchitecture!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants