Enable runtime-configurable HTTPS for smartdns-ui and remove compile-time TLS gating#464
Open
Enable runtime-configurable HTTPS for smartdns-ui and remove compile-time TLS gating#464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https_portsetting instead of being controlled by a compile feature and URL scheme.Description
https_porttoHttpServerConfig, load it from server config and command-line (--https-port), and expose it insettings_map.rustlsTlsAcceptorand a separate HTTPSTcpListenerwhenhttps_port > 0, accepting TLS connections concurrently with HTTP.cfg_ifusage and maketokio-rustls/rustls-pemfileavailable unconditionally by changingCargo.tomlso TLS dependencies are no longer optional and thehttpsfeature no longer maps to them.plugin.rsto accept--https-portand minor whitespace/format cleanup.Testing
cargo build -p smartdns-uiand the build completed successfully.cargo test -p smartdns-uiand all tests passed.Codex Task