peer_id: rewrite parsing and error contracts#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/peer_id/peer_id.cinto helper-driven, bounds-checked parsing/formatting paths for legacy base58 and CIDv1 peer IDspeer_id_to_string()with its documented contract by returning negative error codes on failure and deterministic output reset behaviortests/peer_id/test_peer_id.cwith vector-driven round-trip coverage plus explicit negative/boundary regression checksstandards/rewrite-pilot-6-peer-id.mdValidation
cmake --build --preset macos-full --target peer_id peer_id_proto peer_id_rsa peer_id_ecdsa peer_id_ed25519 test_peer_id test_protocol_noisectest --preset macos-full -R '^(Testpeer_id|Testprotocol_noise)$' --output-on-failurectest --preset macos-full --output-on-failurecmake --preset linux-asan-ubsancmake --build --preset linux-asan-ubsan --target test_peer_id test_protocol_noisectest --preset linux-asan-ubsan -R '^(Testpeer_id|Testprotocol_noise)$' --output-on-failurectest --preset linux-asan-ubsan --output-on-failureclang-format --style=file --dry-run --Werror src/peer_id/peer_id.c src/peer_id/peer_id_rsa.c src/peer_id/peer_id_ecdsa.c src/peer_id/peer_id_ed25519.c tests/peer_id/test_peer_id.ccppcheck --error-exitcode=1 --std=c99 --enable=warning,portability --quiet --suppress=missingIncludeSystem src/multiformats include/multiformats tests/multiformats src/peer_id include/peer_id tests/peer_idscripts/dev/run-fast-lane-local.sh --platform macos