Skip to content

Conversation

@jbreu
Copy link

@jbreu jbreu commented Jan 30, 2017

Hi Pico,

WorkingWarrior and me made necessary changes to your extension in order to make it ready for phpBB 3.2; it is not compatible to any earlier phpBB version < 3.2 as this is not possible.

The only thing I could not yet fix is the aggregation of notifications for the same post and user (function find_users_for_notification). Maybe this can be done by somebody else.

Best regards

Galixte and others added 30 commits February 27, 2015 19:03
FRENCH translation for exceptions.php file
FRENCH translation for info_acp_reputation.php
FRENCH translation for permissions_reputation.php
FRENCH translation for reputation_acp.php
FRENCH translation for reputation_common.php
FRENCH translation for reputation_rating.php
FRENCH translation for reputation_system.php
FRENCH translation for reputation_toplist.php
FRENCH translation for reputation_warning.php
FRENCH translation for info_acp_reputation.php file
FRENCH translation for permissions_reputation.php file
FRENCH translation for reputation_acp.php file
FRENCH translation for reputation_common.php file
FRENCH translation for reputation_rating.php file
FRENCH translation for reputation_system.php file
FRENCH translation for reputation_toplist.php file
FRENCH translation for reputation_warning.php file
Update for FRENCH translation for info_acp_reputation.php file
Update for ENGLISH translation for info_acp_reputation.php file
Update for FRENCH translation for reputation_acp.php file
Minor update for ENGLISH for reputation_acp.php file
Update for reputation_common.php file : Change a language key which already exists (duplicate) in reputation_system.php
Update for reputation_common.php file which already exists (duplicate) in reputation_system.php
@Galixte
Copy link

Galixte commented Jan 30, 2017

Hi @jbreu,

you forgot these previous pull requests: #37 & #38. Could you merge these with your PR ?

@Galixte
Copy link

Galixte commented Feb 1, 2017

Ok, thanks for intagrated the PR38, i will submit you the PR 37 inside your fork. ;)

@jbreu
Copy link
Author

jbreu commented Feb 1, 2017

Sorry, I am new to this stuff 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants