[ON-HOLD][Feature] V3 Board Calibration GUI by connorgallopo · Pull Request #186 · PiTracLM/PiTrac

connorgallopo · 2026-03-21T22:26:30Z

Description

This PR take the foundations from #181 and updates them to be merge ready.

What does this PR do?

Refactors #181 to remove script anti-pattern, moving everything into the gui for an intuitive user experience.

Why is this change needed?

See #181. This change is required on top of 181 as we have removed manual scripts, so using them again is an anti-pattern and a step backwards.

Changes Made

Refactored original script into a python class
Added Tests
Added Controller / API layer
Added gui for functionality on the existing calibration page

Testing Performed

Full gui testing, and the written pytests.

Test Environment

Macbook Dev Env

Hardware Compatibility

Tested on Pi 5
Tested on Pi 4
Tested with single Pi setup
Tested with dual Pi setup

Documentation

AI (Vibe-Coded) Content Description

Tests for original script were generated, then rewritten to test against refactored version to ensure same functionality.

Checklist

Code Quality

Code follows existing patterns and conventions
No unnecessary comments added
Error handling implemented appropriately

Build & Test

Successfully builds with ./packaging/build.sh build
All existing tests pass
New tests added for new functionality
Tested on actual Raspberry Pi hardware (not just CI)

Submission Requirements

Commits squashed if needed (git rebase -i HEAD~n)
CLA signed
PR title follows format: [PR TYPE] Brief description
Branch is up-to-date with main

Additional Context

@peteattayek

peteattayek · 2026-03-22T00:07:19Z

The GUI images look great! This was a much more substantial PR than I was expecting, nice work!

I'll run this with my V3 board and LED and review the functional algo soon

peteattayek · 2026-03-22T10:59:33Z

Software/web-server/strobe_calibration_manager.py

+        try:
+            try:
+                param = os.sched_param(os.sched_get_priority_max(os.SCHED_FIFO))
+                os.sched_setscheduler(0, os.SCHED_FIFO, param)


This requires root privileges to set, is that already implemented?

Ill have to verify the perms of the web-server. But im pretty sure its non-root. From what i read in the original that was a nice to have not a need to have. Is that the case?

If so this does handle it gracefully if it doesnt have root.

Software/web-server/strobe_calibration_manager.py

peteattayek · 2026-03-22T11:29:39Z

@connorgallopo should I rebase/merge this (locally) with feature/build-cleanup branch before testing? I'm planning on doing a completely fresh build to test the dependencies

connorgallopo · 2026-03-22T15:38:03Z

@connorgallopo should I rebase/merge this (locally) with feature/build-cleanup branch before testing? I'm planning on doing a completely fresh build to test the dependencies

if you use the github cli you can just check out the PR - which in my opinion is the best/easiest way. You just will have to have a remote set for this upstream

…I0 MOSI pin (GPIO 10)

…est compat

…cs, manual DAC, etc)

…em gpio backends

…ssages to UI

peteattayek · 2026-03-23T14:10:53Z

This did not work.
build_log.txt

I did a fresh install of 64 bit trixie, then ran:
sudo apt update
sudp apt -y full-upgrade

I did a fresh build of PiTrac off of this branch. The build log is attached.

Smaller issue first: This also did not setup /boot/firmware/config.txt when the cameras were not attached. I intended this to setup all non-camera parameters (like force_turbo=1, dtoverlay=spi1-cs2, etc).

Bigger issue: It seems like there is still an lgpio issue. In the build log I see:
The following packages have unmet dependencies: python3-lgpio : Depends: liblgpio1 (= 0.2.2-1~rpt1+trixie) but 0.2.2-1~trixie1 is to be installed [WARN] Could not install python3-lgpio
This is the same issue I ran into before. I can get calibration to work if I run:
sudo apt install --allow-downgrades liblgpio1=0.2.2-1~rpt1+trixie python3-lgpio python3-rpi-lgpio python3-gpiozero

connorgallopo · 2026-03-23T14:27:52Z

This did not work. build_log.txt

I did a fresh install of 64 bit trixie, then ran: sudo apt update sudp apt -y full-upgrade

I did a fresh build of PiTrac off of this branch. The build log is attached.

Smaller issue first: This also did not setup /boot/firmware/config.txt when the cameras were not attached. I intended this to setup all non-camera parameters (like force_turbo=1, dtoverlay=spi1-cs2, etc).

Bigger issue: It seems like there is still an lgpio issue. In the build log I see: The following packages have unmet dependencies: python3-lgpio : Depends: liblgpio1 (= 0.2.2-1~rpt1+trixie) but 0.2.2-1~trixie1 is to be installed [WARN] Could not install python3-lgpio This is the same issue I ran into before. I can get calibration to work if I run: sudo apt install --allow-downgrades liblgpio1=0.2.2-1~rpt1+trixie python3-lgpio python3-rpi-lgpio python3-gpiozero

Why did you do full upgrade? That is destructive to the default packages that this was tested against.

peteattayek · 2026-03-23T14:37:30Z

This did not work. build_log.txt
I did a fresh install of 64 bit trixie, then ran: sudo apt update sudp apt -y full-upgrade
I did a fresh build of PiTrac off of this branch. The build log is attached.
Smaller issue first: This also did not setup /boot/firmware/config.txt when the cameras were not attached. I intended this to setup all non-camera parameters (like force_turbo=1, dtoverlay=spi1-cs2, etc).
Bigger issue: It seems like there is still an lgpio issue. In the build log I see: The following packages have unmet dependencies: python3-lgpio : Depends: liblgpio1 (= 0.2.2-1~rpt1+trixie) but 0.2.2-1~trixie1 is to be installed [WARN] Could not install python3-lgpio This is the same issue I ran into before. I can get calibration to work if I run: sudo apt install --allow-downgrades liblgpio1=0.2.2-1~rpt1+trixie python3-lgpio python3-rpi-lgpio python3-gpiozero

Why did you do full upgrade? That is destructive to the default packages that this was tested against.

I did it to upgrade rpicam and libcamera. It should not have affected lgpio, but if you want me to re-do it, I can.

connorgallopo · 2026-03-23T14:47:37Z

This did not work. build_log.txt
I did a fresh install of 64 bit trixie, then ran: sudo apt update sudp apt -y full-upgrade
I did a fresh build of PiTrac off of this branch. The build log is attached.
Smaller issue first: This also did not setup /boot/firmware/config.txt when the cameras were not attached. I intended this to setup all non-camera parameters (like force_turbo=1, dtoverlay=spi1-cs2, etc).
Bigger issue: It seems like there is still an lgpio issue. In the build log I see: The following packages have unmet dependencies: python3-lgpio : Depends: liblgpio1 (= 0.2.2-1~rpt1+trixie) but 0.2.2-1~trixie1 is to be installed [WARN] Could not install python3-lgpio This is the same issue I ran into before. I can get calibration to work if I run: sudo apt install --allow-downgrades liblgpio1=0.2.2-1~rpt1+trixie python3-lgpio python3-rpi-lgpio python3-gpiozero

Why did you do full upgrade? That is destructive to the default packages that this was tested against.

I did it to upgrade rpicam and libcamera. It should not have affected lgpio, but if you want me to re-do it, I can.

I would retry - and follow the install docs. The install script should handle all the versioning.

peteattayek · 2026-03-23T17:34:40Z

I have retried following the instructions on the wiki by the letter, and I have the exact same issues

connorgallopo · 2026-03-23T17:45:56Z

I have retried following the instructions on the wiki by the letter, and I have the exact same issues

Ahh this is because James never committed his changes from working on my branch. let me see.

… conflict

…s attached

connorgallopo · 2026-03-23T17:49:00Z

@peteattayek put his changes in.

peteattayek · 2026-03-23T18:39:56Z

I ran sudo ./build.sh dev force this time instead of re-imaging the sd card with a fresh piOS.

I have the exact same issues. config.txt was not setup and the calibration fails because of lgpio issues.

When I run sudo ./configure-cameras.sh I get:
pitrac@pitrac:~/PiTrac/packaging/scripts $ sudo ./configure-cameras.sh [INFO] PiTrac Camera Configuration [INFO] ============================ [INFO] Detecting connected cameras... [WARN] Could not run camera detection - skipping camera configuration [INFO] This may be normal on non-Pi systems or if cameras are not connected

so this is hitting the else condition immediately of if camera_json=$(sudo python3 /usr/lib/pitrac/web-server/camera_detector.py --json 2>/dev/null); then

if I look at the pitrac-web logs when I try to calibrate the LED, I get:
Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from lgpio: No module named 'lgpio' Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from rpigpio: No module named 'RPi' Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from pigpio: No module named 'pigpio' Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from native: unable to open /dev/gpiomem or /dev/mem; upgrade your kernel or run as root Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: 2026-03-23 14:38:47,515 - strobe_calibration_manager - ERROR - Calibration exception: Unable to load any default pin factory!

I can run sudo apt install --allow-downgrades liblgpio1=0.2.2-1~rpt1+trixie python3-lgpio python3-rpi-lgpio python3-gpiozero to fix the issue

connorgallopo · 2026-03-23T19:18:50Z

If you did not do it fresh or properly clean up dependencies, you would still have the previous deps.

I ran sudo ./build.sh dev force this time instead of re-imaging the sd card with a fresh piOS.

I have the exact same issues. config.txt was not setup and the calibration fails because of lgpio issues.

When I run sudo ./configure-cameras.sh I get: pitrac@pitrac:~/PiTrac/packaging/scripts $ sudo ./configure-cameras.sh [INFO] PiTrac Camera Configuration [INFO] ============================ [INFO] Detecting connected cameras... [WARN] Could not run camera detection - skipping camera configuration [INFO] This may be normal on non-Pi systems or if cameras are not connected

so this is hitting the else condition immediately of if camera_json=$(sudo python3 /usr/lib/pitrac/web-server/camera_detector.py --json 2>/dev/null); then

if I look at the pitrac-web logs when I try to calibrate the LED, I get: Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from lgpio: No module named 'lgpio' Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from rpigpio: No module named 'RPi' Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from pigpio: No module named 'pigpio' Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: /usr/local/lib/python3.13/dist-packages/gpiozero/devices.py:300: PinFactoryFallback: Falling back from native: unable to open /dev/gpiomem or /dev/mem; upgrade your kernel or run as root Mar 23 14:38:47 pitrac pitrac-web[6622]: warnings.warn( Mar 23 14:38:47 pitrac pitrac-web[6622]: 2026-03-23 14:38:47,515 - strobe_calibration_manager - ERROR - Calibration exception: Unable to load any default pin factory!

I can run sudo apt install --allow-downgrades liblgpio1=0.2.2-1~rpt1+trixie python3-lgpio python3-rpi-lgpio python3-gpiozero to fix the issue

Yeah that makes sense - as the previous version was still installing the custom lib.

peteattayek · 2026-03-24T00:39:02Z

I did a fresh Trixie install and still have lgpio issues, see the attached build log
meson-log.txt

peteattayek · 2026-03-24T14:47:27Z

These changes fix the issue. They were suggested by Claude Code and I don't know what the other ramifications of these changes would be, but hopefully it can point you in the right direction
5f6642a

connorgallopo · 2026-03-24T15:09:46Z

@peteattayek I wiped a pi and installed with 0 build issues. Please provide the full scope of what OS you install, and your install steps.

@jamespilgrim are you able to test this?

connorgallopo · 2026-03-24T15:14:53Z

I am going to say this gets put on ice until we get another set of eyes on it.

peteattayek · 2026-03-24T15:33:06Z

@peteattayek I wiped a pi and installed with 0 build issues. Please provide the full scope of what OS you install, and your install steps.

@jamespilgrim are you able to test this?

I am using the Raspberry Pi Imager v2.06 to image a 64GB SD card with Raspberry Pi OS (64 bit). The description on the imager says it is a port of Debian Trixie and was released 2025-12-04.

Once I put the SD card into a Raspberry Pi 5, I follow the PiTrac wiki and run:
`sudo apt update
sudo apt -y upgrade
sudo reboot now

git clone https://github.com/PiTracLM/PiTrac.git
cd PiTrac
git checkout feature/v3-calibration-webui
cd packaging
sudo ./build.sh dev`

James is traveling this week. I'll see if anyone else can test it.

@connorgallopo is this what you are doing to build with 0 issues? What are you doing?

connorgallopo · 2026-03-24T15:37:42Z

James is traveling this week. I'll see if anyone else can test it.

There is no rush - Either way it will require testing / approval from a reviewer.

If that is all you are doing why is the working directory changed?

Yes those are the steps.

peteattayek · 2026-03-24T15:57:09Z

I am not sure the working directory change is necessary, but Claude Code said it was to ensure there was write access. And it did fix the errors when I tried to run calibration from the web ui

I don't understand how you can even get PiTrac to build without getting an error about finding the lgpio package without changing line 73 of meson.build since there is no lgpio.pc on the image?? (5f6642a#diff-7852c36152187ba2962691d983613a42aa860af0941298706736e5f1bd805920L73)

Determining dependency 'lgpio' with pkg-config executable '/usr/bin/pkg-config'
env[PKG_CONFIG_PATH]: /usr/lib/aarch64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
env[PKG_CONFIG]: /usr/bin/pkg-config
-----------
Called: `/usr/bin/pkg-config --modversion lgpio` -> 1
stderr:
Package lgpio was not found in the pkg-config search path.
Perhaps you should add the directory containing `lgpio.pc'
to the PKG_CONFIG_PATH environment variable
Package 'lgpio', required by 'virtual:world', not found
-----------
CMake binary for host machine is not cached
CMake binary missing from cross or native file, or env var undefined.
Trying a default CMake fallback at cmake
Did not find CMake 'cmake'
Found CMake: NO
Dependency lookup for lgpio with method 'cmake' failed: CMake binary for machine host machine not found. Giving up.
Run-time dependency lgpio found: NO (tried pkgconfig)

meson.build:73:12: ERROR: Dependency "lgpio" not found, tried pkgconfig

connorgallopo · 2026-03-24T16:00:56Z

It is handled elsewhere.

Claude fueling this debugging seems like it is causing more trouble than anything. And you waited til now to tell me it was having you change paths etc.

So I am going to just run through again myself, and put this on hold for now.

I appreciate your testing efforts

peteattayek · 2026-03-24T16:12:59Z

It is handled elsewhere.

It wasn't handled when I built PiTrac

Claude fueling this debugging seems like it is causing more trouble than anything. And you waited til now to tell me it was having you change paths etc.

I told you the first time I changed something with Claude a few comments ago from this morning (#186 (comment)). It is the first thing that has allowed me to both build successfully and run calibration.

peteattayek · 2026-03-26T01:40:56Z

The latest commit let's me build successfully! There is still an issue with gpiozero needing write access to the working directory. I made a PR to this branch with a suggested change to just use direct liblgpio calls. I have tested this with my hardware and it works.

I did not update test_strobe_calibration_manager.py yet though

peteattayek · 2026-03-26T10:09:52Z

With the latest commit I can now successfully:

Build from source on an RPi5 with a fresh PiOS (Trixie 64bit) install
The config.txt file is modified with non-camera parameters even if cameras are not present
Run calibration successfully!

Remaining major issues:

the "Read Diagnostics" button is dangerous and should only be an "advanced" feature. If the LED is pulsed with the LDO voltage too high (we don't have a good number for this) it can blow out the LED and/or MOSFETS.

Remaining minor issues/suggestions:

After calibration, the LDO voltage is not reported correctly
I suggest adding part of the progress bar to the _find_dac_start function else it looks like calibration hangs at the beginning.

connorgallopo requested review from jamespilgrim and markjonharman March 21, 2026 22:26

connorgallopo mentioned this pull request Mar 21, 2026

Add v3 connector board calibration #181

Closed

25 tasks

peteattayek reviewed Mar 22, 2026

View reviewed changes

Software/web-server/strobe_calibration_manager.py Show resolved Hide resolved

peteattayek reviewed Mar 22, 2026

View reviewed changes

Software/web-server/strobe_calibration_manager.py Outdated Show resolved Hide resolved

peteattayek reviewed Mar 22, 2026

View reviewed changes

Software/web-server/strobe_calibration_manager.py Show resolved Hide resolved

peteattayek and others added 20 commits March 22, 2026 13:45

Add clibrate_strobe_output.py script to web-server folder

c8e66e4

Set current limits for both V3 LED and Old 100W LED

67b5cf0

Update PCB Assembly documentation with connection guide for V3

5ebf706

Update assembly instructions to only say 1 rpi instead of 1-2

f31c82b

Change ADC and DAC to use SPI1 instead of SPI0. Change DIAG pin to SP…

c607151

…I0 MOSI pin (GPIO 10)

Cleanup calibrate_strobe_output.py script

25d5f81

change old led current to 9A

9028d16

Add installation files for spi1 setup and Python runtime dependencies

8e7b717

Update wiring diagram and documentation

0eeab42

make kDAC_setting internal-only, not passed to C++ processes

e9eb3d5

route kDAC_setting to calibration_data.json instead of user_settings

b253925

strobe calibration manager skeleton with hardware open/close

76f469f

add calibration algorithm (_find_dac_start, _calibrate) + fix macOS t…

683d5c4

…est compat

add async public API for strobe calibration (start, cancel, diagnosti…

6e3d083

…cs, manual DAC, etc)

wire strobe calibration API endpoints into server.py

9e0225f

add strobe calibration UI to calibration page

365dfa0

use DigitalOutputDevice instead of LED, harden close and gc handling

1e43577

remove standalone CLI calibration script, replaced by web UI

839c7b0

move strobe deps to web server: pip for spidev/gpiozero, apt for syst…

da8c767

…em gpio backends

fix broken SVG image path in pcb-assembly docs

eaa54dc

connorgallopo added 2 commits March 22, 2026 13:45

fix status polling data, null checks, settle timing, dac sweep edge case

29aed9d

add pre-flight board check, use for loop, surface specific failure me…

c042fb0

…ssages to UI

connorgallopo force-pushed the feature/v3-calibration-webui branch from 92272ed to c042fb0 Compare March 22, 2026 17:46

connorgallopo added 2 commits March 23, 2026 13:48

use system lgpio instead of custom build, fixes python3-lgpio version…

403dc87

… conflict

always configure base system params in config.txt even without camera…

1aaf231

…s attached

fix config.txt setup when no cameras attached

6a91461

connorgallopo changed the title ~~[Feature] V3 Board Calibration GUI~~ [ON-HOLD][Feature] V3 Board Calibration GUI Mar 24, 2026

hardening

1959f68

peteattayek mentioned this pull request Mar 26, 2026

[Feature] replace gpiozero with direct lgpio calls #189

Closed

23 tasks

Add standard fix in place of #189

3a2b832

Uh oh!

Conversation

connorgallopo commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What does this PR do?

Why is this change needed?

Changes Made

Testing Performed

Test Environment

Hardware Compatibility

Documentation

AI (Vibe-Coded) Content Description

Checklist

Code Quality

Build & Test

Submission Requirements

Additional Context

Uh oh!

peteattayek commented Mar 22, 2026

Uh oh!

peteattayek Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

connorgallopo Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peteattayek commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

connorgallopo commented Mar 22, 2026

Uh oh!

peteattayek commented Mar 23, 2026

Uh oh!

connorgallopo commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peteattayek commented Mar 23, 2026

Uh oh!

connorgallopo commented Mar 23, 2026

Uh oh!

peteattayek commented Mar 23, 2026

Uh oh!

connorgallopo commented Mar 23, 2026

Uh oh!

connorgallopo commented Mar 23, 2026

Uh oh!

peteattayek commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

connorgallopo commented Mar 23, 2026

Uh oh!

peteattayek commented Mar 24, 2026

Uh oh!

peteattayek commented Mar 24, 2026

Uh oh!

connorgallopo commented Mar 24, 2026

Uh oh!

connorgallopo commented Mar 24, 2026

Uh oh!

peteattayek commented Mar 24, 2026

Uh oh!

connorgallopo commented Mar 24, 2026

Uh oh!

peteattayek commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

connorgallopo commented Mar 24, 2026

Uh oh!

peteattayek commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peteattayek commented Mar 26, 2026

Uh oh!

peteattayek commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Remaining major issues:

connorgallopo commented Mar 21, 2026 •

edited

Loading

peteattayek commented Mar 22, 2026 •

edited

Loading

connorgallopo commented Mar 23, 2026 •

edited

Loading

peteattayek commented Mar 23, 2026 •

edited

Loading

peteattayek commented Mar 24, 2026 •

edited

Loading

peteattayek commented Mar 24, 2026 •

edited

Loading

peteattayek commented Mar 26, 2026 •

edited

Loading