-
Notifications
You must be signed in to change notification settings - Fork 0
[FEAT] add cmp function #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eigenkyeong
wants to merge
2
commits into
dev
Choose a base branch
from
feat/9-compare-numbers
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| ## 구현 기능 | ||
|
|
||
| - 추가하려는 기능에 대해 간결하게 설명해주세요 | ||
|
|
||
| ## 작업 상세 내용 | ||
|
|
||
| - [ ] TODO | ||
| - [ ] TODO | ||
| - [ ] TODO | ||
|
|
||
| ## 참고할만한 자료(선택) | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: '' | ||
| assignees: '' | ||
| --- | ||
| ## 구현 기능 | ||
| - 추가하려는 기능에 대해 간결하게 설명해주세요 | ||
| ## 작업 상세 내용 | ||
| - [ ] TODO | ||
| - [ ] TODO | ||
| - [ ] TODO | ||
| ## 참고할만한 자료(선택) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,79 @@ | ||
| #include <stdio.h> | ||
| #include "multiply.h" | ||
|
|
||
| // review #2 | ||
| static int s_multi_x = 15; | ||
| static int g_multi_y = 4; | ||
|
|
||
| int sub(int a, int b) | ||
| { | ||
| return a - b; | ||
| } | ||
|
|
||
| int add_numbers(int x, int y) | ||
| { | ||
| int tmp; | ||
| tmp = x + y; | ||
| return tmp; | ||
| } | ||
|
|
||
| int main(void) | ||
| { | ||
| int a, b, c, d; | ||
|
|
||
| printf("Hello World!\n"); | ||
| printf("두 수를 입력하세요.\n"); | ||
|
|
||
| scanf("%d %d", &a, &b); | ||
| c = add_numbers(a, b); | ||
|
|
||
| if (c >= 10) | ||
| { | ||
| printf("10 이상\n"); | ||
| } | ||
| else | ||
| { | ||
| printf("10 미만\n"); | ||
| } | ||
|
|
||
| d = sub(a, b); | ||
|
|
||
| if (d > 0) | ||
| { | ||
| printf("두 수의 차이는 양수입니다.\n"); | ||
| } | ||
| else if (d == 0) | ||
| { | ||
| printf("두 수의 차이는 0입니다.\n"); | ||
| } | ||
| else | ||
| { | ||
| printf("두 수의 차이는 음수입니다.\n"); | ||
| } | ||
| int multi_result = multiply(s_multi_x, g_multi_y); | ||
| printf("Multi : %d\n", multi_result); | ||
|
|
||
| return 0; | ||
| } | ||
| #include <stdio.h> | ||
| #include <stdbool.h> | ||
| #include "multiply.h" | ||
|
|
||
| // review #2 | ||
| static int s_multi_x = 15; | ||
| static int g_multi_y = 4; | ||
|
|
||
| bool cmp(int a, int b) | ||
| { | ||
| if (a > b) | ||
| { | ||
| return true; | ||
| } | ||
| else | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| int sub(int a, int b) | ||
| { | ||
| return a - b; | ||
| } | ||
|
|
||
| int add_numbers(int x, int y) | ||
| { | ||
| int tmp; | ||
| tmp = x + y; | ||
| return tmp; | ||
| } | ||
|
|
||
| int main(void) | ||
| { | ||
| int a, b, c; | ||
|
|
||
| printf("Hello World!\n"); | ||
| printf("두 수를 입력하세요.\n"); | ||
|
|
||
| scanf("%d %d", &a, &b); | ||
| c = add_numbers(a, b); | ||
|
|
||
| if (c >= 10) | ||
| { | ||
| printf("10 이상\n"); | ||
| } | ||
| else | ||
| { | ||
| printf("10 미만\n"); | ||
| } | ||
|
|
||
| d = sub(a, b); | ||
|
|
||
| if (d > 0) | ||
| { | ||
| printf("두 수의 차이는 양수입니다.\n"); | ||
| } | ||
| else if (d == 0) | ||
| { | ||
| printf("두 수의 차이는 0입니다.\n"); | ||
| } | ||
| else | ||
| { | ||
| printf("두 수의 차이는 음수입니다.\n"); | ||
| } | ||
| int multi_result = multiply(s_multi_x, g_multi_y); | ||
| printf("Multi : %d\n", multi_result); | ||
|
|
||
| if (cmp(a, b) == true) | ||
| { | ||
| printf("a is greater than b! :)"); | ||
| } | ||
| else | ||
| { | ||
| printf("a is not greater than b! :("); | ||
| } | ||
|
|
||
| return 0; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오잉 이건 왜 뜨는거지? 변경사항없는디