Add warning message when no weights are loaded for training #815
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderswerdlow
requested review from
kvablack and
uzhilinsky
as code owners
alexanderswerdlow
force-pushed
the
noop_weight_warning
branch
from
f551c39 to
c170d5b
Compare
alexanderswerdlow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect most openpi intend to finetune from a pretrained model and not train from scratch. If
weight_loaderis not overridden, it defaults toNoOpWeightLoaderand it may be helpful to warn the user in this case.This is particularly relevant since the checkpoint loading differs from train vs. inference, where a given config can correctly load the inference weights, but will not use those same weights unless specified in the
weight_loader(orpytorch_weight_path) config.