Issue #10: Removed default "Hello World" response#15
Open
mouri11 wants to merge 6 commits intoPhoenixRRDS:masterfrom
Open
Issue #10: Removed default "Hello World" response#15mouri11 wants to merge 6 commits intoPhoenixRRDS:masterfrom
mouri11 wants to merge 6 commits intoPhoenixRRDS:masterfrom
Conversation
Member
|
Can you create a patch and send the link as a comment in #10 |
Removed the default "Hello World" reply. Also added /libs/Ab.jar to resolve dependency conflicts for the AIML bot. fixes: PhoenixRRDS#10 Signed-off-by: Rohit Das <rohit.das950@gmail.com>
Changed android:layout_width and android:layout_height of Relative- Layout to "match_parent". This will ensure the height and width is adjusted relative to those of the screen. fixes: PhoenixRRDS#12 Signed-off-by: Rohit Das <rohit.das950@gmail.com>
Phase 1: Implementing writing messages and responses to file, named with current date in (dd-MM-yyyy) format. fixes: PhoenixRRDS#13 Signed-off-by: Rohit Das <rohit.das950@gmail.com>
RudraNilBasu
force-pushed
the
master
branch
7 times, most recently
from
b6ebeca to
eebefea
Compare
This reverts commit 8498c0a.
In MainActivity.java, mimicOtherMessage() is used to display bot reply to a user message. As a default message, "Hello World" was kept, but on further development, it turned out to be a bane as it keeps cropping up. So the default reply has been removed. fixes: PhoenixRRDS#10 Signed-off-by: Rohit Das <rohit.das950@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the default "Hello World" reply. Also added /libs/Ab.jar to
resolve dependency conflicts for the AIML bot.
Signed-off-by: Rohit Das rohit.das950@gmail.com