-
Notifications
You must be signed in to change notification settings - Fork 62
Collect toolbar enhancements #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chaneylc
wants to merge
15
commits into
main
Choose a base branch
from
collect-toolbar-enhancements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/fieldbook/tracker/activities/TraitEditorActivity.java
…toolbar-enhancements
…toolbar-enhancements # Conflicts: # app/src/main/java/com/fieldbook/tracker/dialogs/NewTraitDialog.kt
trife
requested changes
Dec 28, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove "Field Book" from Collect activity title
- Move left/right icons on bottom toolbar further to the left/right
- Use this icon for media capture
- Modify media view from tabbed to single view. Each piece of media can be a separate card. Hide cards if media type doesn't exist
- Add back button to media view
- Add theming to media viewer
- Add ability to delete media from media viewer
- Add confirm when deleting values with media that indicate attached media will also be deleted
- If there is no value, don't display the capture button in the camera view
- If there is no saved media, don't display the media button in the camera view
- Remove "Picture/Video/Audio taken successfully" title from dialog
- Change dialog confirm button to "Attach"
- Format picker in camera view renders underneath three button navigation
- Use a three way switch for the format picker (like this)
- Instead of multi media, let's refer to this feature as Attached Media (in trait view, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional media capture options to collect screen. Media types are toggle-able in individual trait pages.
Closes #419
Closes #92
To do:
Change Type
ADDITION(non-breaking change that adds functionality)CHANGE(fix or feature that alters existing functionality)FIX(non-breaking change that resolves an issue)OTHER(use only for changes like tooling, build system, CI, docs, etc.)Release Note
Release Type
For internal use - please leave these unchecked unless you are the one completing the merge.
MAJORMINORWAIT(No immediate release, but the changelog will be still be updated if there is a release note.)